-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/hostmetrics] Unify feature gates for direction
removal
#12105
[receiver/hostmetrics] Unify feature gates for direction
removal
#12105
Conversation
b7c7278
to
e0838ca
Compare
Added "Skip Changelog" to pass CI until #12106 is merged |
@codeboten PTAL and let me know what do you think. I would like to include it in the 0.55.0 release, feel free to remove the blocker label if you disagree |
d74f351
to
a1f436e
Compare
@open-telemetry/collector-contrib-approvers please review/merge or remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but would prefer if @codeboten had a look too if he has more context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question and a comment, this consolidation makes sense to me. However it might be worth capturing here that it wont apply to the disk
scraper just yet as that change hasn't been implemented.
a1f436e
to
25a1d53
Compare
This change replaces set of independent feature gates for transition from the metrics with `direction` attribute with two unified feature gates that are applied on all the metrics reported by the hostmetrics receiver. - `receiver.hostmetricsreceiver.emitMetricsWithDirectionAttribute` - `receiver.hostmetricsreceiver.emitMetricsWithoutDirectionAttribute` Also this introduces the following changes to the transition process: 1. I shifts the transition schedule one release forward since disc scraper is not yet ready to emit the new metrics 2. It removes the warnings. They will be introduced in 0.56.0 when all the scrapers are aligned with the schedule. 3. It introduces an option to emit both the deprecated and the new metrics. This can be useful for users during the transition.
25a1d53
to
8144153
Compare
This seems to be a flaky unrelated prometheus receiver test, submitted #12126 |
Please merge once the build passes. I will wait for it and will start the contrib release procedure. |
@tigrannajaryan, merged |
This change replaces set of independent feature gates for transition from the metrics with
direction
attribute with two unified feature gates that are applied on all the metrics reported by the hostmetrics receiver.receiver.hostmetricsreceiver.emitMetricsWithDirectionAttribute
receiver.hostmetricsreceiver.emitMetricsWithoutDirectionAttribute
Also this introduces the following changes to the transition process:
Link to tracking Issue: #11815