Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flaky test][cmd/opampsupervisor] TestSupervisorStartsWithNoOpAMPServer failure #35033

Closed
crobert-1 opened this issue Sep 5, 2024 · 3 comments
Closed

[flaky test][cmd/opampsupervisor] TestSupervisorStartsWithNoOpAMPServer failure #35033

crobert-1 opened this issue Sep 5, 2024 · 3 comments
Labels
cmd/opampsupervisor needs triage New item requiring triage

Comments

@crobert-1
Copy link
Member

Component(s)

cmd/opampsupervisor

Describe the issue you're reporting

Failing CI/CD action

Failure output:

=== RUN   TestSupervisorStartsWithNoOpAMPServer
    e2e_test.go:158: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/cmd/opampsupervisor/e2e_test.go:158
        	            				D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/cmd/opampsupervisor/e2e_test.go:340
        	Error:      	Received unexpected error:
        	            	error loading config: yaml: line 15: did not find expected hexdecimal number
        	Test:       	TestSupervisorStartsWithNoOpAMPServer
    e2e_test.go:128: Shutting down
--- FAIL: TestSupervisorStartsWithNoOpAMPServer (5.02s)

Potentially related: #34704 was recently merged with changes to this area of code in the test.
@crobert-1 crobert-1 added the needs triage New item requiring triage label Sep 5, 2024
@crobert-1 crobert-1 mentioned this issue Sep 5, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@evan-bradley
Copy link
Contributor

That's almost certainly it, thanks for opening this. I'll see if I can get a fix in quickly.

@evan-bradley evan-bradley mentioned this issue Sep 5, 2024
Merged
evan-bradley added a commit that referenced this issue Sep 5, 2024
@evan-bradley
[chore] Fix Supervisor test on Windows (#35035)
97533e6 
Fixes an issue where YAML values need to be carefully quoted or Windows
paths are interpreted as escaped values.

Also unquote the port number since I think it will be unquoted in most
user configs.

**Link to tracking Issue:**
#35033
@crobert-1
Copy link
Member Author

Resolved by #35035

@github-actions github-actions bot mentioned this issue Sep 10, 2024
Closed
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this issue Sep 12, 2024
@evan-bradley @f7o
[chore] Fix Supervisor test on Windows (open-telemetry#35035)
2963305 
Fixes an issue where YAML values need to be carefully quoted or Windows
paths are interpreted as escaped values.

Also unquote the port number since I think it will be unquoted in most
user configs.

**Link to tracking Issue:**
open-telemetry#35033
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cmd/opampsupervisor needs triage New item requiring triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evan-bradley @crobert-1