[internal/otelarrow] Fix test flake (for 34719) #34889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
changed the title
crobert-1
added
Skip Changelog
jpkrohling
approved these changes
Aug 28, 2024
|
|
…tor-contrib into jmacd/fix34719
…tor-contrib into jmacd/fix34719
|
PR is green and restores a test. Please merge! |
crobert-1
approved these changes
Sep 5, 2024
mwear
approved these changes
Sep 5, 2024
Co-authored-by: Curtis Robert <crobert@splunk.com>
crobert-1
added
the
ready to merge
|
(Unrelated test flakes strike.) |
I've filed #35033, agreed they're unrelated. |
|
Green!!! |
codeboten
approved these changes
Sep 6, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
**Description:** Restore a skipped test, after understanding the nature of the problem. The problem was mostly addressed in open-telemetry#34794, which left the test disabled. The test had been flaky because while testing for an out-of-memory condition, the test could fail for timeout or other reason. To make the test more reliable, this now waits until at least one ArrowTraces span has been received by both components. After one span is available, it checks that the expected log messages are present on both sides. **Link to tracking Issue:** Fixes open-telemetry#34719. **Testing:** ✅ --------- Co-authored-by: Curtis Robert <crobert@splunk.com> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Restore a skipped test, after understanding the nature of the problem.
The problem was mostly addressed in #34794, which left the test disabled. The test had been flaky because while testing for an out-of-memory condition, the test could fail for timeout or other reason. To make the test more reliable, this now waits until at least one ArrowTraces span has been received by both components. After one span is available, it checks that the expected log messages are present on both sides.
Link to tracking Issue:
Fixes #34719.
Testing: ✅