Skip to content

Commit

Permalink
[chore][Ping code owners on new issues] Fix output formatting (#32724)
Browse files Browse the repository at this point in the history
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
I noticed the output of a recent comment made by the `github-actions`
bot had an extra `%s` in its output when pinging code owners on new
issues. This is unnecessary.

Example links:

#32666 (comment)

#32723 (comment)
  • Loading branch information
crobert-1 authored Apr 29, 2024
1 parent 1c13d9e commit 9501bb6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/scripts/ping-codeowners-on-new-issue.sh
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ if [[ -n "${PING_LINES}" ]]; then
# to get the newlines to render correctly, using string formatting
# causes the newlines to be interpreted literally.
echo -e "Pinging code owners:\n${PING_LINES}"
echo -e "Pinging code owners:\n${PING_LINES}\n%s" "${LABELS_COMMENT}" \
echo -e "Pinging code owners:\n${PING_LINES}\n" "${LABELS_COMMENT}" \
| gh issue comment "${ISSUE}" -F -
else
echo "No code owners were found to ping"
Expand Down

0 comments on commit 9501bb6

Please sign in to comment.