Skip to content

Commit

Permalink
set failover connector to alpha (#32216)
Browse files Browse the repository at this point in the history
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

This PR adds the failover connector to the contrib distro and moves the
component to alpha state as all MVP functionality has been put in place.
This PR also adds a bug fix that caused the pipeline selector to
continue switching between the stable and stable + 1 index after a new
stable index has been established.

**Link to tracking Issue:** <Issue number if applicable>

Resolves #32094

**Testing:** <Describe what testing was performed and which tests were
added.>

Additional test case added to check current index after stable check
  • Loading branch information
akats7 authored Apr 22, 2024
1 parent 271aa7a commit 11e85a0
Show file tree
Hide file tree
Showing 8 changed files with 48 additions and 12 deletions.
27 changes: 27 additions & 0 deletions .chloggen/failover-alpha.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: failoverconnector

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: This change puts the failoverconnector into alpha

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [20766]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: []
2 changes: 2 additions & 0 deletions cmd/otelcontribcol/builder-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ connectors:
- gomod: github.com/open-telemetry/opentelemetry-collector-contrib/connector/countconnector v0.98.0
- gomod: github.com/open-telemetry/opentelemetry-collector-contrib/connector/datadogconnector v0.98.0
- gomod: github.com/open-telemetry/opentelemetry-collector-contrib/connector/exceptionsconnector v0.98.0
- gomod: github.com/open-telemetry/opentelemetry-collector-contrib/connector/failoverconnector v0.98.0
- gomod: github.com/open-telemetry/opentelemetry-collector-contrib/connector/grafanacloudconnector v0.98.0
- gomod: github.com/open-telemetry/opentelemetry-collector-contrib/connector/routingconnector v0.98.0
- gomod: github.com/open-telemetry/opentelemetry-collector-contrib/connector/servicegraphconnector v0.98.0
Expand Down Expand Up @@ -429,6 +430,7 @@ replaces:
- github.com/open-telemetry/opentelemetry-collector-contrib/connector/countconnector => ../../connector/countconnector
- github.com/open-telemetry/opentelemetry-collector-contrib/connector/datadogconnector => ../../connector/datadogconnector
- github.com/open-telemetry/opentelemetry-collector-contrib/connector/exceptionsconnector => ../../connector/exceptionsconnector
- github.com/open-telemetry/opentelemetry-collector-contrib/connector/failoverconnector => ../../connector/failoverconnector
- github.com/open-telemetry/opentelemetry-collector-contrib/connector/grafanacloudconnector => ../../connector/grafanacloudconnector
- github.com/open-telemetry/opentelemetry-collector-contrib/connector/routingconnector => ../../connector/routingconnector
- github.com/open-telemetry/opentelemetry-collector-contrib/connector/servicegraphconnector => ../../connector/servicegraphconnector
Expand Down
2 changes: 2 additions & 0 deletions cmd/otelcontribcol/components.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions cmd/otelcontribcol/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ require (
github.com/open-telemetry/opentelemetry-collector-contrib/connector/countconnector v0.98.0
github.com/open-telemetry/opentelemetry-collector-contrib/connector/datadogconnector v0.98.0
github.com/open-telemetry/opentelemetry-collector-contrib/connector/exceptionsconnector v0.98.0
github.com/open-telemetry/opentelemetry-collector-contrib/connector/failoverconnector v0.98.0
github.com/open-telemetry/opentelemetry-collector-contrib/connector/grafanacloudconnector v0.98.0
github.com/open-telemetry/opentelemetry-collector-contrib/connector/routingconnector v0.98.0
github.com/open-telemetry/opentelemetry-collector-contrib/connector/servicegraphconnector v0.98.0
Expand Down Expand Up @@ -1156,6 +1157,8 @@ replace github.com/open-telemetry/opentelemetry-collector-contrib/connector/data

replace github.com/open-telemetry/opentelemetry-collector-contrib/connector/exceptionsconnector => ../../connector/exceptionsconnector

replace github.com/open-telemetry/opentelemetry-collector-contrib/connector/failoverconnector => ../../connector/failoverconnector

replace github.com/open-telemetry/opentelemetry-collector-contrib/connector/grafanacloudconnector => ../../connector/grafanacloudconnector

replace github.com/open-telemetry/opentelemetry-collector-contrib/connector/routingconnector => ../../connector/routingconnector
Expand Down
11 changes: 6 additions & 5 deletions connector/failoverconnector/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,20 @@
<!-- status autogenerated section -->
| Status | |
| ------------- |-----------|
| Distributions | [] |
| Distributions | [contrib] |
| Issues | [![Open issues](https://img.shields.io/github/issues-search/open-telemetry/opentelemetry-collector-contrib?query=is%3Aissue%20is%3Aopen%20label%3Aconnector%2Ffailover%20&label=open&color=orange&logo=opentelemetry)](https://github.com/open-telemetry/opentelemetry-collector-contrib/issues?q=is%3Aopen+is%3Aissue+label%3Aconnector%2Ffailover) [![Closed issues](https://img.shields.io/github/issues-search/open-telemetry/opentelemetry-collector-contrib?query=is%3Aissue%20is%3Aclosed%20label%3Aconnector%2Ffailover%20&label=closed&color=blue&logo=opentelemetry)](https://github.com/open-telemetry/opentelemetry-collector-contrib/issues?q=is%3Aclosed+is%3Aissue+label%3Aconnector%2Ffailover) |
| [Code Owners](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#becoming-a-code-owner) | [@akats7](https://www.github.com/akats7), [@djaglowski](https://www.github.com/djaglowski), [@fatsheep9146](https://www.github.com/fatsheep9146) |

[development]: https://github.com/open-telemetry/opentelemetry-collector#development
[alpha]: https://github.com/open-telemetry/opentelemetry-collector#alpha
[contrib]: https://github.com/open-telemetry/opentelemetry-collector-releases/tree/main/distributions/otelcol-contrib

## Supported Pipeline Types

| [Exporter Pipeline Type] | [Receiver Pipeline Type] | [Stability Level] |
| ------------------------ | ------------------------ | ----------------- |
| metrics | metrics | [development] |
| traces | traces | [development] |
| logs | logs | [development] |
| traces | traces | [alpha] |
| metrics | metrics | [alpha] |
| logs | logs | [alpha] |

[Exporter Pipeline Type]: https://github.com/open-telemetry/opentelemetry-collector/blob/main/connector/README.md#exporter-pipeline-type
[Receiver Pipeline Type]: https://github.com/open-telemetry/opentelemetry-collector/blob/main/connector/README.md#receiver-pipeline-type
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions connector/failoverconnector/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ scope_name: otelcol/failover
status:
class: connector
stability:
development: [metrics_to_metrics, traces_to_traces, logs_to_logs]
distributions: []
alpha: [traces_to_traces, metrics_to_metrics, logs_to_logs]
distributions: [contrib]
codeowners:
active: [akats7, djaglowski, fatsheep9146]

tests:
skip_lifecycle: true
skip_shutdown: true
skip_lifecycle: true
skip_shutdown: true
1 change: 1 addition & 0 deletions reports/distributions/contrib.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ components:
- count
- datadog
- exceptions
- failover
- grafanacloud
- routing
- servicegraph
Expand Down

0 comments on commit 11e85a0

Please sign in to comment.