set failover connector to alpha #32216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmd/otelcontribcol
|
Hey @djaglowski, let me know if I should split the bug fix and alpha/distro update into separate PRs. |
crobert-1
reviewed
Apr 8, 2024
cmd/otelcontribcol/go.mod
Outdated
| @@ -8,6 +8,8 @@ require ( | |||
| github.com/open-telemetry/opentelemetry-collector-contrib/connector/countconnector v0.97.0 | |||
| github.com/open-telemetry/opentelemetry-collector-contrib/connector/datadogconnector v0.97.0 | |||
| github.com/open-telemetry/opentelemetry-collector-contrib/connector/exceptionsconnector v0.97.0 | |||
| github.com/open-telemetry/opentelemetry-collector-contrib/connector/failoverconnector v0.97.0 | |||
| github.com/open-telemetry/opentelemetry-collector-contrib/connector/routingconnector v0.97.0 | |||
There was a problem hiding this comment.
Suggested change
| github.com/open-telemetry/opentelemetry-collector-contrib/connector/routingconnector v0.97.0 |
The routing connector is already added as required a few lines below.
There was a problem hiding this comment.
Ah yep thanks that shouldn’t be there. Will update
We really should do one thing at a time. |
|
Thanks for splitting out the bug fix. That one is merged. |
akats7
changed the title
|
Hey @djaglowski, updated to include just move to alpha |
crobert-1
reviewed
Apr 19, 2024
| @@ -4,11 +4,11 @@ scope_name: otelcol/failover | |||
| status: | |||
| class: connector | |||
| stability: | |||
| development: [metrics_to_metrics, traces_to_traces, logs_to_logs] | |||
| distributions: [] | |||
| alpha: [traces_to_traces, metrics_to_metrics, logs_to_logs] | |||
There was a problem hiding this comment.
You'll need to run make generate to make sure the component's README also gets updated.
|
Failing CI/CD : |
djaglowski
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the failover connector to the contrib distro and moves the component to alpha state as all MVP functionality has been put in place. This PR also adds a bug fix that caused the pipeline selector to continue switching between the stable and stable + 1 index after a new stable index has been established.
Link to tracking Issue:
Resolves #32094
Testing:
Additional test case added to check current index after stable check