Check bool examples, don't crash on nonexistent examples. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
added
bug
Oberon00
commented
Aug 3, 2021
| position = attribute.lc.data[list(attribute)[0]] | ||
| msg = "Empty examples for {} are not allowed".format(attr_type) | ||
| raise ValidationError.from_yaml_pos(position, msg) | ||
| if is_simple_type and attr_type not in ["boolean", "boolean[]"]: |
There was a problem hiding this comment.
@thisthat Any idea why this was originally excluded? To support more boolean values like "yes" instead of "true"?
There was a problem hiding this comment.
I think we excluded boolean attributes from having an example because it is not very useful to have true/false there.
There was a problem hiding this comment.
I know they are not required to have examples (though before this patch, non-array bools without examples would have crashed the generator). But in case they do have examples (which is allowed), the examples should still be checked for whether they have the right type.
Oberon00
commented
Aug 3, 2021
semantic-conventions/src/opentelemetry/semconv/model/semantic_attribute.py
Outdated
Show resolved
Hide resolved
Oberon00
added a commit
to dynatrace-oss-contrib/opentelemetry-specification
that referenced
this pull request
Aug 3, 2021
This is a demo for open-telemetry/build-tools#57. (also needs open-telemetry/build-tools#58)
mariojonke
approved these changes
Aug 6, 2021
semantic-conventions/src/opentelemetry/semconv/model/semantic_attribute.py
Outdated
Show resolved
Hide resolved
…attribute.py Co-authored-by: Mario Jonke <mario.jonke@dynatrace.com>
arminru
reviewed
Aug 13, 2021
semantic-conventions/src/opentelemetry/semconv/model/semantic_attribute.py
Outdated
Show resolved
Hide resolved
…attribute.py Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
arminru
reviewed
Aug 13, 2021
semantic-conventions/src/tests/data/yaml/errors/examples/example_bool.yaml
Outdated
Show resolved
Hide resolved
arminru
approved these changes
Aug 13, 2021
mariojonke
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't run into this in the spec yet, but if we ever want to remove some integer examples, we will.