Check bool examples, don't crash on nonexistent examples.

semantic-conventions/semconv.schema.json

@@ -276,8 +276,14 @@
 							"description": "additional notes to the attribute. It defaults to an empty string."
 						},
 						"examples": {
-							"$ref": "#/definitions/ValueType",
-							"description": "sequence/dictionary of example values for the attribute. They are optional for boolean and enum attributes. Example values must be of the same type of the attribute. If only a single example is provided, it can directly be reported without encapsulating it into a sequence/dictionary."
+							"anyOf": [
+								{ "$ref": "#/definitions/ValueType" },
+								{
+									"type": "array",
+									"items": { "$ref": "#/definitions/ValueType" }
+								}
+							],
+							"description": "sequence/dictionary of example values for the attribute. They are optional for boolean, int, double, and enum attributes. Example values must be of the same type of the attribute. If only a single example is provided, it can directly be reported without encapsulating it into a sequence/dictionary."
 						},
 						"deprecated": {
 							"type": "string",

semantic-conventions/src/opentelemetry/semconv/model/semantic_attribute.py

@@ -250,25 +250,25 @@ def parse_id(attribute):
             position = attribute.lc.data[list(attribute)[0]]
             msg = "Non array examples for {} are not allowed".format(attr_type)
             raise ValidationError.from_yaml_pos(position, msg)
-        if (
-            (is_simple_type or isinstance(attr_type, EnumAttributeType))
-            and not isinstance(examples, CommentedSeq)
-            and examples is not None
-        ):
+        if not isinstance(examples, CommentedSeq) and examples is not None:
+            # TODO: If validation fails later, this will crash when trying to access positio data
+            # since a list, contratry to a CommentedSeq, does not have position data
             examples = [examples]
-        if is_simple_type and attr_type not in [
+        if is_simple_type and attr_type not in (
             "boolean",
             "boolean[]",
             "int",
             "int[]",
             "double",
             "double[]",
-        ]:
-            if examples is None or (len(examples) == 0):
+        ):
+            if not examples:
                 position = attribute.lc.data[list(attribute)[0]]
                 msg = "Empty examples for {} are not allowed".format(attr_type)
                 raise ValidationError.from_yaml_pos(position, msg)
-        if is_simple_type and attr_type not in ["boolean", "boolean[]"]:
+
+        # TODO: Implement type check for enum examples or forbid them
+        if examples is not None and is_simple_type:
             AttributeType.check_examples_type(attr_type, examples, zlass)
         return attr_type, str(brief), examples
 

semantic-conventions/src/opentelemetry/semconv/version.py

@@ -12,4 +12,4 @@
 #   See the License for the specific language governing permissions and
 #   limitations under the License.
 
-__version__ = "0.4.1"
+__version__ = "0.4.2"

semantic-conventions/src/tests/data/markdown/single/general.yaml

@@ -56,7 +56,6 @@ groups:
       - id: host.port
         type: int
         brief: 'Like `net.peer.port` but for the host port.'
-        examples: 35555
       - id: host.name
         type: string
         brief: 'Local hostname or similar, see note below.'
@@ -83,4 +82,4 @@ groups:
           Scopes or granted authorities the client currently possesses extracted from token
           or application security context. The value would come from the scope associated
           with an OAuth 2.0 Access Token or an attribute value in a SAML 2.0 Assertion.
-        examples: 'read:message, write:files'
+        examples: 'read:message, write:files'

semantic-conventions/src/tests/data/yaml/errors/examples/example_bool.yaml

@@ -9,4 +9,4 @@ groups:
         type: boolean
         required: always
         brief: 'test'
-        examples: [true, false, yes]
+        examples: [true, false, true]

semantic-conventions/src/tests/data/yaml/errors/examples/example_bool_array.yaml

@@ -9,4 +9,4 @@ groups:
         type: boolean[]
         required: always
         brief: 'test'
-        examples: [[true,false], [true, 1]]
+        examples: [[true,false], [true, false]]