Fixing memory leaks as reported by valgrind #8747
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applying fixes from open-mpi#8217 These are not my changes, but I'm trying to incorporate them from the v4.0.x PR open-mpi#8217. Signed-off-by: Geoffrey Paulsen <gpaulsen@us.ibm.com>
gpaulsen
added a commit
to gpaulsen/ompi
that referenced
this pull request
Mar 31, 2021
On RHEL 8.3, the version of clang-format that Redhat provides is: > clang-format --version clang-format version 10.0.1 (Red Hat 10.0.1-1.module+el8.3.0+7459+90c24896) > git --version git v2.27.0 I tried to fix up master PR open-mpi#8747 (master version of 8723) with the command: `git clang-format -v HEAD~1` but ran into some issues with clang-format v10.0.1 being able to parse the .clang-format file. I did not spend much time trying to find viable alternatives, instead I would just remove the offending line in the .clang-format file and rince/repeat. Are these options that we could do without, so that we could run clang-format with both v10 and v11? Signed-off-by: Geoffrey Paulsen <gpaulsen@us.ibm.com>
gpaulsen
added a commit
to gpaulsen/ompi
that referenced
this pull request
Mar 31, 2021
These are not my changes, but I'm trying to incorporate them from the v4.0.x PR open-mpi#8217. v4.0.x version of master PR open-mpi#8747 Not a cherry-pick (includes orte and openib changes) Signed-off-by: Geoffrey Paulsen gpaulsen@us.ibm.com
gpaulsen
added a commit
to gpaulsen/ompi
that referenced
this pull request
Mar 31, 2021
These are not my changes, but I'm trying to incorporate them from the v4.0.x PR open-mpi#8217. v4.0.x version of master PR open-mpi#8747 Cherry-picked from the v4.0.x version, since master is missing a few of these files. Signed-off-by: Geoffrey Paulsen gpaulsen@us.ibm.com (cherry picked from commit 3a243ac)
gpaulsen
added a commit
to gpaulsen/ompi
that referenced
this pull request
Mar 31, 2021
These are not my changes, but I'm trying to incorporate them from the v4.0.x PR open-mpi#8217. v4.1.x version of master PR open-mpi#8747 Cherry-picked from the v4.0.x version, since master is missing a few of these files. Signed-off-by: Geoffrey Paulsen gpaulsen@us.ibm.com (cherry picked from commit 3a243ac)
awlauria
suggested changes
Apr 5, 2021
Contributor
awlauria
left a comment
awlauria
left a comment
There was a problem hiding this comment.
Can you remove the line number references? They will get stale real quick.
| { | ||
| if( ! mca_common_monitoring_enabled || /* Don't release if not last */ | ||
| 0 < opal_atomic_sub_fetch_32(&mca_common_monitoring_hold, 1) ) return; | ||
| /* Even if not enabled, this string is allocated at l.310 */ |
| if (!mca_common_monitoring_enabled) { | ||
| if (NULL != mca_common_monitoring_current_filename) { | ||
| free(mca_common_monitoring_current_filename); | ||
| mca_common_monitoring_current_filename = NULL; |
| free(ompi_mtl_ofi.comm_to_context); | ||
| free(ompi_mtl_ofi.ofi_ctxt); | ||
|
|
||
| /* This was strdup()ed at L.714 */ |
Contributor
There was a problem hiding this comment.
It looks like this is 1024. but having line numbers is always dicey. I'd say remove the line reference.
| hp->page_size, hp->path, hp->mmap_flags); | ||
| OBJ_RELEASE(hp); | ||
| } | ||
| OBJ_RELEASE(hp); |
Contributor
There was a problem hiding this comment.
It looks like hp->path is leaked on line 274.
awlauria
changed the title
awlauria
changed the title
gpaulsen
added a commit
to gpaulsen/ompi
that referenced
this pull request
Apr 14, 2021
On RHEL 8.3, the version of clang-format that Redhat provides is: > clang-format --version clang-format version 10.0.1 (Red Hat 10.0.1-1.module+el8.3.0+7459+90c24896) > git --version git v2.27.0 I tried to fix up master PR open-mpi#8747 (master version of 8723) with the command: `git clang-format -v HEAD~1` but ran into some issues with clang-format v10.0.1 being able to parse the .clang-format file. I did not spend much time trying to find viable alternatives, instead I would just remove the offending line in the .clang-format file and rince/repeat. Are these options that we could do without, so that we could run clang-format with both v10 and v11? Signed-off-by: Geoffrey Paulsen <gpaulsen@us.ibm.com> (cherry picked from commit 2a0f095)
Contributor
|
@gpaulsen why close this? At the very least we can get it into master/v5.0.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying fixes from #8217
These are not my changes, but I'm trying to incorporate them
from the v4.0.x PR #8217.
Signed-off-by: Geoffrey Paulsen gpaulsen@us.ibm.com