Fixing .clang-format to allow it to work with v10 #8748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On RHEL 8.3, the version of clang-format that Redhat provides is: > clang-format --version clang-format version 10.0.1 (Red Hat 10.0.1-1.module+el8.3.0+7459+90c24896) > git --version git v2.27.0 I tried to fix up master PR open-mpi#8747 (master version of 8723) with the command: `git clang-format -v HEAD~1` but ran into some issues with clang-format v10.0.1 being able to parse the .clang-format file. I did not spend much time trying to find viable alternatives, instead I would just remove the offending line in the .clang-format file and rince/repeat. Are these options that we could do without, so that we could run clang-format with both v10 and v11? Signed-off-by: Geoffrey Paulsen <gpaulsen@us.ibm.com>
|
Discussed briefly on the chat today, to ask people's opinions. |
hjelmn
approved these changes
Apr 14, 2021
|
Thanks @Helmn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On RHEL 8.3, the version of clang-format that Redhat provides is:
I tried to fix up master PR #8747 (master version of 8723) with the command:
git clang-format -v HEAD~1but ran into some issues with clang-formatv10.0.1 being able to parse the .clang-format file.
I did not spend much time trying to find viable alternatives, instead
I would just remove the offending line in the .clang-format file and
rince/repeat.
Are these options that we could do without, so that we could run
clang-format with both v10 and v11?
Signed-off-by: Geoffrey Paulsen gpaulsen@us.ibm.com