MPI_T: provide a stub implementation of events #13086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsquyres per your request at last weeks meeting. |
|
related to #8057 |
bosilca
reviewed
Feb 12, 2025
jsquyres
previously approved these changes
Feb 12, 2025
There was a problem hiding this comment.
In general, I think this looks like a great first step -- the API is there, and is conformant (even though it doesn't actually do anything). Extensions to make this API more functional would be welcome after this PR.
Any chance we could get some man pages and/or a mention somewhere in the docs about MPI_T events?
|
i'll add man pages to this PR. |
|
@hppritcha I made a few suggestions to your first cut of the man page. |
Signed-off-by: Howard Pritchard <howardp@lanl.gov>
hppritcha
force-pushed
the
mpi_t_events_stub
branch
from
12d6502 to
5622889
Compare
|
@jsquyres please review |
|
@jsquyres ping |
jsquyres
reviewed
Feb 27, 2025
|
Just for the heckuvit, I pushed more to the See Also on MPI_T.3. |
jsquyres
approved these changes
Mar 1, 2025
Signed-off-by: Howard Pritchard <howardp@lanl.gov>
hppritcha
force-pushed
the
mpi_t_events_stub
branch
from
19ea3fa to
d0037fc
Compare
Open
hppritcha
added a commit
to hppritcha/ompi
that referenced
this pull request
Apr 15, 2025
Turns out I forgot to run the pcvs checker when adding MPI_T event stubs in PR open-mpi#13086 and missed a couple of events related functions. Also it looks like these were not included in PR open-mpi#8057. With this patch, the PCVS MPI API checker passes for MPI 4.0 standard. The PCVS MPI API checker is described here https://dl.acm.org/doi/abs/10.1145/3615318.3615329 Signed-off-by: Howard Pritchard <howardp@lanl.gov>
vogma
pushed a commit
to vogma/ompi
that referenced
this pull request
Apr 22, 2025
Turns out I forgot to run the pcvs checker when adding MPI_T event stubs in PR open-mpi#13086 and missed a couple of events related functions. Also it looks like these were not included in PR open-mpi#8057. With this patch, the PCVS MPI API checker passes for MPI 4.0 standard. The PCVS MPI API checker is described here https://dl.acm.org/doi/abs/10.1145/3615318.3615329 Signed-off-by: Howard Pritchard <howardp@lanl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
man pages included in this PR.