fortran: fix common symbol sizes and alignments #13230
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fortran common blocks have extra alignment requirements:
Will update the commit message later. |
ggouaillardet
force-pushed
the
topic/fortran_common_alignment
branch
6 times, most recently
from
1f6b2fc to
5c8fbd6
Compare
with mpif-h and usempi, MPI constants (e.g. MPI_COMM_WORLD) are all parts of a unique common block. Fortran compilers generally have alignment requirements for these (16 with gfortran, 32 with ifort or 64 with nvfortran to name a few), so pass these requirements to the actual symbols that are defined in the C code to make pick linkers (e.g. ubuntu) happy pandas. Such linkers also complain about the size of MPI_STATUS, so define these are arrays intead of pointer. Refs open-mpi#13043 Thanks MJ Rutter for the report Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
ggouaillardet
force-pushed
the
topic/fortran_common_alignment
branch
from
5c8fbd6 to
18fe17f
Compare
|
Just to create a corresponding cross-link: I stole this commit and put it in #13231, and updated the Perl to Python (and fixed the missing dim in the C variable instance from the version of this commit that I copied; I think you fixed it here in a later push). Have a look at #13231 and see what you think. We could possibly use #13231 for main / v6.0.x, and re-target this PR for v5.0.x...? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #13043
Thanks MJ Rutter for the report