btl/uct: correctly set the completion status before using uct complet… #13032
+16
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjelmn
force-pushed
the
fix_flaw_in_btl_uct_because_i_did_not_fully_read_the_documentation_when_the_callbacks_were_changes_and_noone_noticed
branch
from
3e289b1 to
f3baeba
Compare
bosilca
approved these changes
Jan 10, 2025
…ions According to UCT documentation the status field must be preset to UCS_OK before the completion is used. My assumption here is that the field is not filled in in all cases leaving the value as potentially garbage. This CL addresses the issue but setting the status in the constructor for both RDMA completions and frags. The status is then reset on completion callback. Signed-off-by: Nathan Hjelm <hjelmn@google.com>
jsquyres
force-pushed
the
fix_flaw_in_btl_uct_because_i_did_not_fully_read_the_documentation_when_the_callbacks_were_changes_and_noone_noticed
branch
from
f3baeba to
d586292
Compare
|
I rebased this PR (no content change) in an attempt to try to clear the RTD CI error. |
|
RTD CI problem resolved. @hjelmn George approved, so if you're good with this, go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ions
According to UCT documentation the status field must be preset to UCS_OK before the completion is used. My assumption here is that the field is not filled in in all cases leaving the value as potentially garbage. This CL addresses the issue but setting the status in the constructor for both RDMA completions and frags. The status is then reset on completion callback.