v5.0.x: Remove the use of [OPAL|OMPI|OSHMEM]_MODULE_DECLSPEC #10775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In native Microsoft Windows builds, there is difference in how MCA component struct symbols need to be exported compared to other symbols. The "MODULE_DECLSPEC" macros were for exporting MCA component struct symbols, and "DECLSPEC" macros were for all exporting all other symbols. In other operating systems, there's no difference in how these two types of symbols are exported. Once Open MPI stopped supporting native Microsoft Windows builds, there was no need to preserve the difference. This commit therefore does the following: - Removes all definitions of the "MODULE_DECLSPEC" macros - Converts all uses of the "MODULE_DECLSPEC" macros to "DECLSPEC" - Removes stale Microsoft Windows declarations in oshmem_config.h Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 17a1f97)
bosilca
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In native Microsoft Windows builds, there is difference in how MCA component struct symbols need to be exported compared to other symbols. The "MODULE_DECLSPEC" macros were for exporting MCA component struct symbols, and "DECLSPEC" macros were for all exporting all other symbols.
In other operating systems, there's no difference in how these two types of symbols are exported.
Once Open MPI stopped supporting native Microsoft Windows builds, there was no need to preserve the difference. This commit therefore does the following:
Signed-off-by: Jeff Squyres jsquyres@cisco.com
(cherry picked from commit 17a1f97)
This is the v5.0.x PR for #10774