Remove the use of [OPAL|OMPI|OSHMEM]_MODULE_DECLSPEC #10774
Conversation
In native Microsoft Windows builds, there is difference in how MCA component struct symbols need to be exported compared to other symbols. The "MODULE_DECLSPEC" macros were for exporting MCA component struct symbols, and "DECLSPEC" macros were for all exporting all other symbols. In other operating systems, there's no difference in how these two types of symbols are exported. Once Open MPI stopped supporting native Microsoft Windows builds, there was no need to preserve the difference. This commit therefore does the following: - Removes all definitions of the "MODULE_DECLSPEC" macros - Converts all uses of the "MODULE_DECLSPEC" macros to "DECLSPEC" - Removes stale Microsoft Windows declarations in oshmem_config.h Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
|
@bosilca @bwbarrett Can you think of any reason we still need Also, need confirmation from @janjust that OpenSHEMEM does not support native Windows builds (because this PR removes some |
|
I think dumping the module-specific declspec is fine. We should decide what we want to do with 5.0 and either keep this patch back until 5.0 is done with the mass backports or also push it to 5.0. |
|
Just confirming, we do not support windows in OSHMEM |
I'd be in favor of cherry-picking this to v5.0.x in the immediate future -- there's no reason to hold it back, is there? |
In native Microsoft Windows builds, there is difference in how MCA component struct symbols need to be exported compared to other symbols. The "MODULE_DECLSPEC" macros were for exporting MCA component struct symbols, and "DECLSPEC" macros were for all exporting all other symbols.
In other operating systems, there's no difference in how these two types of symbols are exported.
Once Open MPI stopped supporting native Microsoft Windows builds, there was no need to preserve the difference. This commit therefore does the following:
Signed-off-by: Jeff Squyres jsquyres@cisco.com
Related to the conversation on #10770.