Skip to content

MINOR - Prepare extra validations for system repository health #24846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmbrull merged 3 commits into from
Dec 18, 2025
Merged

MINOR - Prepare extra validations for system repository health #24846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9e8b5c
MINOR - Prepare extra validations for system repository health
pmbrull Dec 16, 2025
bfddd85
Update generated TypeScript types
github-actions[bot] Dec 16, 2025
f29cd1c
Merge branch 'main' into om-ai-199
pmbrull Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions docker/development/docker-compose-fuseki.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,9 @@ services:
memory: 4G
reservations:
memory: 2G
networks:
- app_net
# Create the database directory before starting Fuseki
entrypoint: /bin/sh -c "mkdir -p /fuseki/databases/openmetadata && exec /docker-entrypoint.sh /jena-fuseki/fuseki-server --update --loc=/fuseki/databases/openmetadata /openmetadata"

volumes:
fuseki-data:
driver: local

networks:
Copy link
Collaborator Author

@pmbrull pmbrull Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is intended (though not related). Just helps spinning up Fuseki standalone. Otherwise networks were clashing

app_net:
driver: bridge
ipam:
driver: default
config:
- subnet: 172.16.240.0/24
5 changes: 5 additions & 0 deletions openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/SystemRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,9 +525,14 @@ public ValidationResponse validateSystem(
validation.setLogStorage(logStorageValidation);
}

addExtraValidations(applicationConfig, validation);

return validation;
}

public void addExtraValidations(
OpenMetadataApplicationConfig applicationConfig, ValidationResponse validation) {}

private StepValidation getDatabaseValidation(OpenMetadataApplicationConfig applicationConfig) {
try {
dao.testConnection();
Expand Down
2 changes: 1 addition & 1 deletion openmetadata-spec/src/main/resources/json/schema/system/validationResponse.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,5 +53,5 @@
"$ref": "#/definitions/stepValidation"
}
},
"additionalProperties": false
"additionalProperties": true
}
1 change: 1 addition & 0 deletions openmetadata-ui/src/main/resources/ui/src/generated/system/validationResponse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ export interface ValidationResponse {
* Search instance connectivity check
*/
searchInstance?: StepValidation;
[property: string]: any;
}

/**
Expand Down
Loading