-
Notifications
You must be signed in to change notification settings - Fork 1.6k
MINOR - Prepare extra validations for system repository health #24846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
TypeScript types have been updated based on the JSON schema changes in the PR |
| fuseki-data: | ||
| driver: local | ||
|
|
||
| networks: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change is intended (though not related). Just helps spinning up Fuseki standalone. Otherwise networks were clashing
🔍 CI failure analysis for f29cd1c: Playwright tests failed again with DIFFERENT tests failing on retry, strongly confirming flakiness. The tests are unrelated to PR changes. This has hit the retry limit.IssueThe Root CauseDifferent tests failed on retry, strongly confirming these are flaky E2E tests:
Only 2 tests (Tag & Users) failed consistently across both runs. The different failures between runs is a classic flakiness pattern. DetailsThis PR only modifies system validation files ( StatusThis job has now been retried once (max retry limit reached per Flaky Test Retry rule). The persistent failures in Tag.spec.ts and Users.spec.ts may indicate a real issue in those specific tests that needs investigation by the test maintainers, but it is not caused by this PR. Code Review 👍 Approved with suggestionsReasonable extensibility changes with one minor type safety concern around allowing arbitrary properties. Suggestions 💡 1 suggestionCode Quality: Schema change allows arbitrary properties, reducing type safety📄 openmetadata-spec/src/main/resources/json/schema/system/validationResponse.json:56 Changing Impact:
Suggestion: Recommendations
The changes appear to be setting up an extension point for custom validations, which is a valid architectural pattern. The docker-compose network cleanup looks like straightforward maintenance. Tip Comment OptionsAuto-apply is off Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | This comment will update automatically (Docs) |
|
|
|
Changes have been cherry-picked to the 1.11.4 branch. |
* MINOR - Prepare extra validations for system repository health * Update generated TypeScript types --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 6fdc353)
* MINOR - Prepare extra validations for system repository health * Update generated TypeScript types --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>



Describe your changes:
1.11.4 - help us expand the validations
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Summary by Gitar
addExtraValidations()hook inSystemRepository.javafor subclasses to add custom health checksvalidationResponse.jsonto allowadditionalPropertiesfor new validation fieldsdocker-compose-fuseki.ymlThis will update automatically on new commits.