-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AnalogIO refactoring and support for buffering and data type conversions #92
Conversation
The order of samples in the buffer is currently incorrect. We need somehow to get each channel (C) sample from raw frames:
into the analog buffer with a BufferSize-sample (N) stride:
Currently, data is ordered like this:
The obvious ways of doing this will have a significant performance impact, I would imaging (e.g. looping over the data). |
@jonnew oh, so it's actually a demuxed row major order? That's even better, I can just get rid of the transpose then, and it will be even more efficient! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from these issues, I'm encountering a strange behavior with my hardware. If I ground an analog input, I see a significant offset voltage (-1V or so). I'm not sure if this an issue with my hardware, hardware design, or HDL. If you can try to reproduce it would be helpful.
I have verified that this now appears to be functioning well. There is an issue with the analog input, but I think its either hardware or gateware related and may even be specific to my prototype hardware. Its documented here: open-ephys/onix-fmc-host#8. Let me know if you see this -0.9V offset on grounded analog inputs on your hardware when you have time to test |
@jonnew Just did the test this morning and I don't see this offset (there was a very slight 20mV offset but this could well be the harp device DIO we used for testing, as we were seeing this on the oscilloscope as well). |
AnalogInputDataFrame
and expose analog data usingMat
typesFixes #79