Skip to content

Commit 1fd4978

Browse files
authored
Merge pull request #77 from neurogears/api-refactor
Rename hub clock to hub sync counter
2 parents ac9806c + 65dd7d7 commit 1fd4978

12 files changed

+44
-44
lines changed

OpenEphys.Onix/OpenEphys.Onix/Bno055DataFrame.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public unsafe Bno055DataFrame(oni.Frame frame)
1414
internal unsafe Bno055DataFrame(ulong clock, Bno055Payload* payload)
1515
: this(clock, &payload->Data)
1616
{
17-
HubClock = payload->HubClock;
17+
HubSyncCounter = payload->HubSyncCounter;
1818
}
1919

2020
internal unsafe Bno055DataFrame(ulong clock, Bno055DataPayload* payload)
@@ -43,7 +43,7 @@ internal unsafe Bno055DataFrame(ulong clock, Bno055DataPayload* payload)
4343

4444
public ulong Clock { get; }
4545

46-
public ulong HubClock { get; }
46+
public ulong HubSyncCounter { get; }
4747

4848
public Vector3 EulerAngle { get; }
4949

@@ -61,7 +61,7 @@ internal unsafe Bno055DataFrame(ulong clock, Bno055DataPayload* payload)
6161
[StructLayout(LayoutKind.Sequential, Pack = 1)]
6262
unsafe struct Bno055Payload
6363
{
64-
public ulong HubClock;
64+
public ulong HubSyncCounter;
6565
public Bno055DataPayload Data;
6666
}
6767

OpenEphys.Onix/OpenEphys.Onix/HarpSyncInputDataFrame.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,21 +8,21 @@ public unsafe HarpSyncInputDataFrame(oni.Frame frame)
88
{
99
Clock = frame.Clock;
1010
var payload = (HarpSyncInputPayload*)frame.Data.ToPointer();
11-
HubClock = payload->HubClock;
11+
HubSyncCounter = payload->HubSyncCounter;
1212
HarpTime = payload->HarpTime;
1313
}
1414

1515
public ulong Clock { get; }
1616

17-
public ulong HubClock { get; }
17+
public ulong HubSyncCounter { get; }
1818

1919
public uint HarpTime { get; }
2020
}
2121

2222
[StructLayout(LayoutKind.Sequential, Pack = 1)]
2323
struct HarpSyncInputPayload
2424
{
25-
public ulong HubClock;
25+
public ulong HubSyncCounter;
2626
public uint HarpTime;
2727
}
2828
}

OpenEphys.Onix/OpenEphys.Onix/MemoryUsageDataFrame.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public unsafe MemoryUsageDataFrame(oni.Frame frame, uint totalMemory)
1111

1212
FrameClock = frame.Clock;
1313
DeviceAddress = frame.DeviceAddress;
14-
HubClock = payload->HubClock;
14+
HubSyncCounter = payload->HubSyncCounter;
1515
PercentUsed = 100.0 * payload->Usage / totalMemory;
1616
BytesUsed = payload->Usage * 4;
1717

@@ -21,7 +21,7 @@ public unsafe MemoryUsageDataFrame(oni.Frame frame, uint totalMemory)
2121

2222
public uint DeviceAddress { get; private set; }
2323

24-
public ulong HubClock { get; }
24+
public ulong HubSyncCounter { get; }
2525

2626
public double PercentUsed { get; }
2727

@@ -31,7 +31,7 @@ public unsafe MemoryUsageDataFrame(oni.Frame frame, uint totalMemory)
3131
[StructLayout(LayoutKind.Sequential, Pack = 1)]
3232
struct MemoryUsagePayload
3333
{
34-
public ulong HubClock;
34+
public ulong HubSyncCounter;
3535
public uint Usage;
3636
}
3737
}

OpenEphys.Onix/OpenEphys.Onix/NeuropixelsV2eBetaData.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,27 +34,27 @@ public unsafe override IObservable<NeuropixelsV2eBetaDataFrame> Generate()
3434
var sampleIndex = 0;
3535
var amplifierBuffer = new ushort[NeuropixelsV2eBeta.ChannelCount, bufferSize];
3636
var frameCounter = new int[NeuropixelsV2eBeta.FramesPerSuperFrame * bufferSize];
37-
var hubClockBuffer = new ulong[bufferSize];
37+
var hubSyncCounterBuffer = new ulong[bufferSize];
3838
var clockBuffer = new ulong[bufferSize];
3939

4040
var frameObserver = Observer.Create<oni.Frame>(
4141
frame =>
4242
{
4343
var payload = (NeuropixelsV2BetaPayload*)frame.Data.ToPointer();
4444
NeuropixelsV2eBetaDataFrame.CopyAmplifierBuffer(payload->SuperFrame, amplifierBuffer, frameCounter, sampleIndex);
45-
hubClockBuffer[sampleIndex] = payload->HubClock;
45+
hubSyncCounterBuffer[sampleIndex] = payload->HubSyncCounter;
4646
clockBuffer[sampleIndex] = frame.Clock;
4747
if (++sampleIndex >= bufferSize)
4848
{
4949
var amplifierData = Mat.FromArray(amplifierBuffer);
5050
var dataFrame = new NeuropixelsV2eBetaDataFrame(
5151
clockBuffer,
52-
hubClockBuffer,
52+
hubSyncCounterBuffer,
5353
amplifierData,
5454
frameCounter);
5555
observer.OnNext(dataFrame);
5656
frameCounter = new int[NeuropixelsV2eBeta.FramesPerSuperFrame * bufferSize];
57-
hubClockBuffer = new ulong[bufferSize];
57+
hubSyncCounterBuffer = new ulong[bufferSize];
5858
clockBuffer = new ulong[bufferSize];
5959
sampleIndex = 0;
6060
}

OpenEphys.Onix/OpenEphys.Onix/NeuropixelsV2eBetaDataFrame.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,17 @@ namespace OpenEphys.Onix
55
{
66
public class NeuropixelsV2eBetaDataFrame
77
{
8-
public NeuropixelsV2eBetaDataFrame(ulong[] clock, ulong[] hubClock, Mat amplifierData, int[] frameCounter)
8+
public NeuropixelsV2eBetaDataFrame(ulong[] clock, ulong[] hubSyncCounter, Mat amplifierData, int[] frameCounter)
99
{
1010
Clock = clock;
11-
HubClock = hubClock;
11+
HubSyncCounter = hubSyncCounter;
1212
AmplifierData = amplifierData;
1313
FrameCounter = frameCounter;
1414
}
1515

1616
public ulong[] Clock { get; }
1717

18-
public ulong[] HubClock { get; }
18+
public ulong[] HubSyncCounter { get; }
1919

2020
public Mat AmplifierData { get; }
2121

@@ -81,7 +81,7 @@ internal static unsafe void CopyAmplifierBuffer(ushort* superFrame, ushort[,] am
8181
[StructLayout(LayoutKind.Sequential, Pack = 1)]
8282
unsafe struct NeuropixelsV2BetaPayload
8383
{
84-
public ulong HubClock;
84+
public ulong HubSyncCounter;
8585
public ushort ProbeIndex;
8686
public uint Reserved;
8787
public fixed ushort SuperFrame[NeuropixelsV2eBeta.FramesPerSuperFrame * NeuropixelsV2eBeta.FrameWords];

OpenEphys.Onix/OpenEphys.Onix/NeuropixelsV2eData.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,21 +33,21 @@ public unsafe override IObservable<NeuropixelsV2eDataFrame> Generate()
3333
{
3434
var sampleIndex = 0;
3535
var amplifierBuffer = new ushort[NeuropixelsV2e.ChannelCount, bufferSize];
36-
var hubClockBuffer = new ulong[bufferSize];
36+
var hubSyncCounterBuffer = new ulong[bufferSize];
3737
var clockBuffer = new ulong[bufferSize];
3838

3939
var frameObserver = Observer.Create<oni.Frame>(
4040
frame =>
4141
{
4242
var payload = (NeuropixelsV2Payload*)frame.Data.ToPointer();
4343
NeuropixelsV2eDataFrame.CopyAmplifierBuffer(payload->AmplifierData, amplifierBuffer, sampleIndex);
44-
hubClockBuffer[sampleIndex] = payload->HubClock;
44+
hubSyncCounterBuffer[sampleIndex] = payload->HubSyncCounter;
4545
clockBuffer[sampleIndex] = frame.Clock;
4646
if (++sampleIndex >= bufferSize)
4747
{
4848
var amplifierData = Mat.FromArray(amplifierBuffer);
49-
observer.OnNext(new NeuropixelsV2eDataFrame(clockBuffer, hubClockBuffer, amplifierData));
50-
hubClockBuffer = new ulong[bufferSize];
49+
observer.OnNext(new NeuropixelsV2eDataFrame(clockBuffer, hubSyncCounterBuffer, amplifierData));
50+
hubSyncCounterBuffer = new ulong[bufferSize];
5151
clockBuffer = new ulong[bufferSize];
5252
sampleIndex = 0;
5353
}

OpenEphys.Onix/OpenEphys.Onix/NeuropixelsV2eDataFrame.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,16 @@ namespace OpenEphys.Onix
55
{
66
public class NeuropixelsV2eDataFrame
77
{
8-
public NeuropixelsV2eDataFrame(ulong[] clock, ulong[] hubClock, Mat amplifierData)
8+
public NeuropixelsV2eDataFrame(ulong[] clock, ulong[] hubSyncCounter, Mat amplifierData)
99
{
1010
Clock = clock;
11-
HubClock = hubClock;
11+
HubSyncCounter = hubSyncCounter;
1212
AmplifierData = amplifierData;
1313
}
1414

1515
public ulong[] Clock { get; }
1616

17-
public ulong[] HubClock { get; }
17+
public ulong[] HubSyncCounter { get; }
1818

1919
public Mat AmplifierData { get; }
2020

@@ -93,7 +93,7 @@ internal static unsafe void CopyAmplifierBuffer(ushort* amplifierData, ushort[,]
9393
[StructLayout(LayoutKind.Sequential, Pack = 1)]
9494
unsafe struct NeuropixelsV2Payload
9595
{
96-
public ulong HubClock;
96+
public ulong HubSyncCounter;
9797
public ushort ProbeIndex;
9898
public ulong Reserved;
9999
public fixed ushort AmplifierData[NeuropixelsV2e.ChannelCount];

OpenEphys.Onix/OpenEphys.Onix/Rhd2164Data.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public unsafe override IObservable<Rhd2164DataFrame> Generate()
2828
var device = deviceInfo.GetDeviceContext(typeof(Rhd2164));
2929
var amplifierBuffer = new short[Rhd2164.AmplifierChannelCount * bufferSize];
3030
var auxBuffer = new short[Rhd2164.AuxChannelCount * bufferSize];
31-
var hubClockBuffer = new ulong[bufferSize];
31+
var hubSyncCounterBuffer = new ulong[bufferSize];
3232
var clockBuffer = new ulong[bufferSize];
3333

3434
var frameObserver = Observer.Create<oni.Frame>(
@@ -37,14 +37,14 @@ public unsafe override IObservable<Rhd2164DataFrame> Generate()
3737
var payload = (Rhd2164Payload*)frame.Data.ToPointer();
3838
Marshal.Copy(new IntPtr(payload->AmplifierData), amplifierBuffer, sampleIndex * Rhd2164.AmplifierChannelCount, Rhd2164.AmplifierChannelCount);
3939
Marshal.Copy(new IntPtr(payload->AuxData), auxBuffer, sampleIndex * Rhd2164.AuxChannelCount, Rhd2164.AuxChannelCount);
40-
hubClockBuffer[sampleIndex] = payload->HubClock;
40+
hubSyncCounterBuffer[sampleIndex] = payload->HubSyncCounter;
4141
clockBuffer[sampleIndex] = frame.Clock;
4242
if (++sampleIndex >= bufferSize)
4343
{
4444
var amplifierData = BufferHelper.CopyBuffer(amplifierBuffer, bufferSize, Rhd2164.AmplifierChannelCount, Depth.U16);
4545
var auxData = BufferHelper.CopyBuffer(auxBuffer, bufferSize, Rhd2164.AuxChannelCount, Depth.U16);
46-
observer.OnNext(new Rhd2164DataFrame(clockBuffer, hubClockBuffer, amplifierData, auxData));
47-
hubClockBuffer = new ulong[bufferSize];
46+
observer.OnNext(new Rhd2164DataFrame(clockBuffer, hubSyncCounterBuffer, amplifierData, auxData));
47+
hubSyncCounterBuffer = new ulong[bufferSize];
4848
clockBuffer = new ulong[bufferSize];
4949
sampleIndex = 0;
5050
}

OpenEphys.Onix/OpenEphys.Onix/Rhd2164DataFrame.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,17 @@ namespace OpenEphys.Onix
55
{
66
public class Rhd2164DataFrame
77
{
8-
public Rhd2164DataFrame(ulong[] clock, ulong[] hubClock, Mat amplifierData, Mat auxData)
8+
public Rhd2164DataFrame(ulong[] clock, ulong[] hubSyncCounter, Mat amplifierData, Mat auxData)
99
{
1010
Clock = clock;
11-
HubClock = hubClock;
11+
HubSyncCounter = hubSyncCounter;
1212
AmplifierData = amplifierData;
1313
AuxData = auxData;
1414
}
1515

1616
public ulong[] Clock { get; }
1717

18-
public ulong[] HubClock { get; }
18+
public ulong[] HubSyncCounter { get; }
1919

2020
public Mat AmplifierData { get; }
2121

@@ -25,7 +25,7 @@ public Rhd2164DataFrame(ulong[] clock, ulong[] hubClock, Mat amplifierData, Mat
2525
[StructLayout(LayoutKind.Sequential, Pack = 1)]
2626
unsafe struct Rhd2164Payload
2727
{
28-
public ulong HubClock;
28+
public ulong HubSyncCounter;
2929
public fixed ushort AmplifierData[Rhd2164.AmplifierChannelCount];
3030
public fixed ushort AuxData[Rhd2164.AuxChannelCount];
3131
}

OpenEphys.Onix/OpenEphys.Onix/TS4231DataFrame.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,15 @@ public unsafe TS4231DataFrame(oni.Frame frame)
88
{
99
Clock = frame.Clock;
1010
var payload = (TS4231Payload*)frame.Data.ToPointer();
11-
HubClock = payload->HubClock;
11+
HubSyncCounter = payload->HubSyncCounter;
1212
SensorIndex = payload->SensorIndex;
1313
EnvelopeWidth = payload->EnvelopeWidth;
1414
EnvelopeType = payload->EnvelopeType;
1515
}
1616

1717
public ulong Clock { get; }
1818

19-
public ulong HubClock { get; }
19+
public ulong HubSyncCounter { get; }
2020

2121
public int SensorIndex { get; }
2222

@@ -28,7 +28,7 @@ public unsafe TS4231DataFrame(oni.Frame frame)
2828
[StructLayout(LayoutKind.Sequential, Pack = 1)]
2929
struct TS4231Payload
3030
{
31-
public ulong HubClock;
31+
public ulong HubSyncCounter;
3232
public ushort SensorIndex;
3333
public uint EnvelopeWidth;
3434
public TS4231Envelope EnvelopeType;

0 commit comments

Comments
 (0)