-
Notifications
You must be signed in to change notification settings - Fork 11
#26 allow connecting through http server #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#26 allow connecting through http server #28
Conversation
* Added additional string parameter 'connection_state'. Allow modifying it through the HTTP config interface to connect/disconnect the socket
* Cleanup and a small clarification
bparks13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start, thank you for submitting it! I have a few comments, and some suggestions, please take a look at them and change those sections.
|
@tzijnge One more thing, please go to the
|
* Addressing review comments. Removed parameter to simplify code and process of connecting and disconnecting remotely * Update library version
* revert unrelated changes
Done |
bparks13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I tested this and was able to connect/disconnect/query the connection status successfully. Thanks for the help with this.
|
@tzijnge I have merged this to the main branch. It is not deployed to the plugin manager yet, I will wait to do that until we have updated the documentation. Let me know if you would like to take a shot at doing that, or I would be happy to take care of it. |
|
@bparks13 I have also updated the documentation and created a PR. Thanks for the collaboration! |
Uh oh!
There was an error while loading. Please reload this page.