-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Changes to Instance for day2 in API #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into add_api_osupdatepolicy
Merged
3 tasks
SushilLakra
previously approved these changes
May 26, 2025
… into add_api_instance_day2
pierventre
reviewed
May 28, 2025
pierventre
reviewed
May 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about (OPTIONAL)
. Either we enforce this or we remove
pierventre
approved these changes
May 28, 2025
raphaelvrosa
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several updates to the API and internal codebase, primarily focusing on deprecating certain fields, adding new fields for runtime and OS update details, and updating validation logic. The changes aim to improve the clarity and functionality of instance resource management.
Deprecations and Replacements:
desired_os
andcurrent_os
fields as deprecated in favor ofOSUpdatePolicy
for day2 operations andos
for day0 operations. These changes are reflected in both the OpenAPI spec and protocol buffer definitions.update_status_detail
field, recommending the use ofOSUpdateRun
instead.New Fields for Runtime and OS Updates:
runtimePackages
andosUpdateAvailable
fields to represent runtime package details and OS update availability, respectively. These fields are included in the OpenAPI spec, protocol buffer definitions, and documentation.Code Adjustments:
runtimePackages
andosUpdateAvailable
) in theInstanceResource
structure.ITEP-67231
Any Newly Introduced Dependencies
Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: