Skip to content

feat: Changes to Instance for day2 in API #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 28, 2025
Merged

Conversation

daniele-moro
Copy link
Contributor

@daniele-moro daniele-moro commented May 26, 2025

Description

This pull request introduces several updates to the API and internal codebase, primarily focusing on deprecating certain fields, adding new fields for runtime and OS update details, and updating validation logic. The changes aim to improve the clarity and functionality of instance resource management.

Deprecations and Replacements:

  • Marked desired_os and current_os fields as deprecated in favor of OSUpdatePolicy for day2 operations and os for day0 operations. These changes are reflected in both the OpenAPI spec and protocol buffer definitions.
  • Deprecated the update_status_detail field, recommending the use of OSUpdateRun instead.

New Fields for Runtime and OS Updates:

  • Added runtimePackages and osUpdateAvailable fields to represent runtime package details and OS update availability, respectively. These fields are included in the OpenAPI spec, protocol buffer definitions, and documentation.

Code Adjustments:

  • Added placeholders in the server logic for populating the new fields (runtimePackages and osUpdateAvailable) in the InstanceResource structure.

ITEP-67231

Any Newly Introduced Dependencies

Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I agree to use the APACHE-2.0 license for my code changes
  • I have not introduced any 3rd party dependency changes
  • I have performed a self-review of my code

SushilLakra
SushilLakra previously approved these changes May 26, 2025
Base automatically changed from add_api_osupdatepolicy to main May 28, 2025 14:48
@daniele-moro daniele-moro dismissed SushilLakra’s stale review May 28, 2025 14:48

The base branch was changed.

@sys-orch sys-orch added the apiv2 label May 28, 2025
Copy link
Contributor

@pierventre pierventre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about (OPTIONAL). Either we enforce this or we remove

@daniele-moro daniele-moro enabled auto-merge (squash) May 28, 2025 18:00
@daniele-moro daniele-moro merged commit ca5e001 into main May 28, 2025
20 checks passed
@daniele-moro daniele-moro deleted the add_api_instance_day2 branch May 28, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants