[ITEP-67228] Updated OperatingSystem Resource as per the design for day2 updates for apiv2 #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n for day2 updates
SushilLakra
requested review from
Andrea-Campanella,
cjnolan,
damiankopyto,
daniele-moro,
ikyrycho,
jkossak,
ktaube26,
niket-intc,
osinstom,
Paiadhithi,
PalashGoelIntel,
pierventre,
raphaelvrosa,
rranjan3,
soniabha-intc,
sunil-parida,
tmatenko,
zdw and
krishnajs
as code owners
There was a problem hiding this comment.
Overall LGTM, @raphaelvrosa let's agree on the deprecation.
…edge-platform/infra-core into itep-67228-day2-upgrade-br
pierventre
reviewed
May 27, 2025
It's a problem of plugins version. APIv2 is not running generate target in CI (for unknown reason), so we are facing these issues now. |
daniele-moro
approved these changes
May 28, 2025
Co-authored-by: Daniele Moro <9449199+daniele-moro@users.noreply.github.com>
…removed OperatingSystemResourceFieldDescription from os.go
… into itep-67228-day2-upgrade-br
… into itep-67228-day2-upgrade-br
daniele-moro
approved these changes
May 28, 2025
jkossak
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated OperatingSystem Resource as per the design for day2 updates for apiv2
Fixes # (issue)
Changes in OSProfile:
installed_packages: field is used to track only packages installed at day 0, for Immutable these come from the Manifest file published together with the EMT image. For Mutable, those are filled using the Ubuntu manifest file. For Mutable, this won't include Bare Metal Agents packages, since those are installed during Day 0, but they are not part of the Ubuntu manifest.
installed_packages_source: field is the URL where the Manifest file is stored. The field is immutable. This is added to allow manual creation of OSProfiles (advanced feature).
update_sources: the field is deprecated, and should not be used anymore.
kernel_commands: the field is deprecated, and should not be used anymore.
installed_packages: read-only from API
installed_pacakges_source: r/w from API
update_sources: deprecate
kernel_commands: deprecate
Any Newly Introduced Dependencies
No
How Has This Been Tested?
Internal Unit Testing for apiv2 has been successfully executed.
Checklist: