Consolidate on-prem-installer deb packages #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Halim, Abdul <abdul.halim@intel.com>
Signed-off-by: Halim, Abdul <abdul.halim@intel.com>
Signed-off-by: Halim, Abdul <abdul.halim@intel.com>
Signed-off-by: Halim, Abdul <abdul.halim@intel.com>
Signed-off-by: Halim, Abdul <abdul.halim@intel.com>
Signed-off-by: Halim, Abdul <abdul.halim@intel.com>
Signed-off-by: Halim, Abdul <abdul.halim@intel.com>
This reverts commit d975dde.
Signed-off-by: Halim, Abdul <abdul.halim@intel.com>
This reverts commit cd02597.
Signed-off-by: Halim, Abdul <abdul.halim@intel.com>
Signed-off-by: Halim, Abdul <abdul.halim@intel.com>
Signed-off-by: Halim, Abdul <abdul.halim@intel.com>
ahalimx86
changed the title
Signed-off-by: Halim, Abdul <abdul.halim@intel.com>
Signed-off-by: Halim, Abdul <abdul.halim@intel.com>
ahalimx86
requested review from
se-chris-thach,
palade,
mdbalvin,
ashridatta and
sys-orch-approve
as code owners
ahalimx86
requested review from
johnoloughlin,
garyloug,
rad-szulim,
charlesmcchan,
yi-tseng-intel,
teone,
callumnobleintel,
daniele-moro,
SeanCondon,
pierventre,
cgoea,
pperycz,
ltalarcz and
jakubsikorski
as code owners
ahalimx86
changed the title
Signed-off-by: Halim, Abdul <abdul.halim@intel.com>
garyloug
approved these changes
May 30, 2025
|
Reviewing now |
se-chris-thach
approved these changes
May 30, 2025
Comment on lines
+25
to
+27
| # disable loading of kernel modules at boot | ||
| rm -fr /etc/modules-load.d/lv-snapshots.conf | ||
|
|
Comment on lines
+139
to
+161
| // Enable kernel modules required for LV snapshots | ||
| func configModules() error { | ||
| fmt.Println("config kernel modules...") | ||
|
|
||
| mods, err := os.OpenFile("/etc/modules-load.d/lv-snapshots.conf", os.O_RDWR|os.O_CREATE|os.O_TRUNC, 0o644) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| defer mods.Close() | ||
|
|
||
| if _, err = mods.WriteString("dm-snapshot\ndm-mirror\n"); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if err = sh.RunV("modprobe", "dm-snapshot"); err != nil { | ||
| return err | ||
| } | ||
| if err = sh.RunV("modprobe", "dm-mirror"); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return nil | ||
| } |
There was a problem hiding this comment.
This will also be deleted in #381
Comment on lines
+102
to
+103
| "-d", "jq,libpq5,apparmor,lvm2,mosquitto,net-tools,ntp,openssh-server", //nolint:misspell | ||
| "-d", "software-properties-common,tpm2-abrmd,tpm2-tools,unzip", |
There was a problem hiding this comment.
curious, where did these deps come from? We can probably audit and remove these later.
Like how does RKE2 depend on openssh-server? 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consolidate on-prem-installer deb packages:
This PR depends on #352 which needs to be merged first
Fixes # (issue)
Any Newly Introduced Dependencies
Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: