Skip to content

[WIP] consolidate onprem argocd and gitea deb package #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

ahalimx86
Copy link
Contributor

@ahalimx86 ahalimx86 commented May 22, 2025

Description

Consolidate onprem argocd and gitea deb packages in one under onprem-argo-cd

Fixes # (issue)

Any Newly Introduced Dependencies

Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I agree to use the APACHE-2.0 license for my code changes
  • I have not introduced any 3rd party dependency changes
  • I have performed a self-review of my code

ahalimx86 added 8 commits May 22, 2025 14:13
Signed-off-by: Halim, Abdul <abdul.halim@intel.com>
Signed-off-by: Halim, Abdul <abdul.halim@intel.com>
Signed-off-by: Halim, Abdul <abdul.halim@intel.com>
Signed-off-by: Halim, Abdul <abdul.halim@intel.com>
Signed-off-by: Halim, Abdul <abdul.halim@intel.com>
Signed-off-by: Halim, Abdul <abdul.halim@intel.com>
Signed-off-by: Halim, Abdul <abdul.halim@intel.com>
@ahalimx86
Copy link
Contributor Author

@se-chris-thach Please take a look. It's now passing local onprem deployment in dev environment. I kept the consolidated code in onprem-argo-cd but do you have any other name suggestion to use for both argo and gitea?

Copy link
Contributor

@se-chris-thach se-chris-thach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 10/10 🚢

@se-chris-thach se-chris-thach enabled auto-merge May 30, 2025 19:45
@se-chris-thach se-chris-thach added this pull request to the merge queue May 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants