Fixes and updates to make the module work #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `GhidraDecompilation` class is not used anywhere. Remove it from the `configuration.py` file. Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>
There may be cases when there is a missing symlink or a man page file is not accessible. Handle exception of opening that file: do nothing, return from the generator function. Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>
Add reference to the `pyprojects.toml` file in the `commons` repository. The `pyelftools` v0.28 package version results in build error (unable to locate `RelrRelocationSection`). It's not part of the `relocation.py` file: https://github.com/eliben/pyelftools/blob/v0.28/elftools/elf/relocation.py Version v0.29 of `pyelftools` defines `RelrRelocationSection`: https://github.com/eliben/pyelftools/blob/v0.29/elftools/elf/relocation.py#L110 Update the version of `pyelftools` in `pyprojects.toml`. Meaning using the line below in `pyprojects.toml`: ``` pyelftools = "^0.29" ``` Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>
It is generally recommended to include `poetry.lock` to the repository. This helps with using the same package versions that are known to work. The absence of the `poetry.lock` file will force Poetry to generate a new one, that may result in package versions that fail to wor Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>
attack_surface_approximation/dictionaries_generators/heuristics/man_parsing.py
Outdated
Show resolved
Hide resolved
ClaraStefania
requested changes
Dec 27, 2024
razvand
force-pushed
the
razvand/fix/fix-setup
branch
2 times, most recently
from
9abf9d7 to
045bb24
Compare
Improve instructions in `README.md` on installing and setting up the module. Add detailed instructions, fix commands where required, reference the `dataset` and `commons` modules. Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>
Use version `^24.3.0` to fix vulnerability in the dependabot alert #1 (on GitHub). Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>
A `return` line is present by mistake outside the scope of a function. Remove it. Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>
razvand
force-pushed
the
razvand/fix/fix-setup
branch
from
045bb24 to
686d0f7
Compare
ClaraStefania
approved these changes
Dec 27, 2024
AmaliaI12
requested changes
Jan 9, 2025
| export PYTHON_KEYRING_BACKEND=keyring.backends.null.Keyring | ||
| ``` | ||
|
|
||
| This is an problem that may occur in certain situations, preventing Poetry from getting packages. |
There was a problem hiding this comment.
Suggested change
| This is an problem that may occur in certain situations, preventing Poetry from getting packages. | |
| This is a problem that may occur in certain situations, preventing Poetry from getting packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration fixes to make the
attack_surface_approximationmodule work. Improve instructions on using the module.