Update pyproject.toml deps #7
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using python 3.12 will result into an error because distutils is no longer supported. Downgrading to python 3.10 will solve this issue. Signed-off-by: Sorin Birchi <sb.birchi.sorin@gmail.com>
razvand
requested changes
Apr 8, 2024
There was a problem hiding this comment.
Hi, @SorinAlexB.
In the commit message, make it wrap at 72 characters. Use Python instead of python. Use present tense instead of future tense. Mention in the commit message that the downgrade is the update to pyproject.toml.
Do a separate commit to add the commons line. They are two different items.
Use dependencies instead of deps.
I'm being extra pedantic with this, to assist you in creating great commit messages in the future.
|
@SorinAlexB , I'm closing this PR in favor of #8 that includes these changes as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using python 3.12 will result into an error
because distutils is no longer supported. Downgrading to python 3.10 will solve this issue.