Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update placements templates to v1beta1 #63

Conversation

ilan-pinto
Copy link
Member

No description provided.

@TomerFi TomerFi linked an issue May 3, 2023 that may be closed by this pull request
@TomerFi TomerFi changed the title modfied placment chore: modified placements templates May 3, 2023
@TomerFi
Copy link
Member

TomerFi commented May 3, 2023

This should also be done for the HelmRepo and ObjectBucket templates. As well as for the snippet itself.

@TomerFi TomerFi changed the title chore: modified placements templates chore: update placements templates and snippet May 3, 2023
@ilan-pinto ilan-pinto force-pushed the 29-update-placement-snippets-and-templates branch from 0b1fc4b to d80fd82 Compare May 3, 2023 11:57
@ilan-pinto
Copy link
Member Author

@TomerFi can we merge this?

@TomerFi TomerFi changed the title chore: update placements templates and snippet chore: update placements templates to v1beta1 May 3, 2023
@TomerFi TomerFi marked this pull request as ready for review May 3, 2023 18:27
@openshift-ci openshift-ci bot requested review from TomerFi and zvigrinberg May 3, 2023 18:27
@openshift-ci
Copy link

openshift-ci bot commented May 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ilan-pinto, TomerFi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TomerFi TomerFi force-pushed the 29-update-placement-snippets-and-templates branch from 24635b6 to 27b92b8 Compare May 3, 2023 18:33
@openshift-ci openshift-ci bot removed the lgtm label May 3, 2023
@TomerFi
Copy link
Member

TomerFi commented May 3, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 3, 2023
Signed-off-by: Ilan Pinto <ilpinto@redhat.com>
@TomerFi TomerFi force-pushed the 29-update-placement-snippets-and-templates branch from 27b92b8 to c509454 Compare May 3, 2023 18:33
@openshift-ci openshift-ci bot removed the lgtm label May 3, 2023
@TomerFi
Copy link
Member

TomerFi commented May 3, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit b7f7e14 into open-cluster-management-io:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Placement snippets and templates
3 participants