-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update placements templates to v1beta1 #63
Merged
openshift-merge-robot
merged 1 commit into
open-cluster-management-io:main
from
ilan-pinto:29-update-placement-snippets-and-templates
May 3, 2023
Merged
chore: update placements templates to v1beta1 #63
openshift-merge-robot
merged 1 commit into
open-cluster-management-io:main
from
ilan-pinto:29-update-placement-snippets-and-templates
May 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerFi
changed the title
chore: modified placements templates
chore: update placements templates and snippet
May 3, 2023
ilan-pinto
force-pushed
the
29-update-placement-snippets-and-templates
branch
from
May 3, 2023 11:57
0b1fc4b
to
d80fd82
Compare
@TomerFi can we merge this? |
TomerFi
changed the title
chore: update placements templates and snippet
chore: update placements templates to v1beta1
May 3, 2023
TomerFi
approved these changes
May 3, 2023
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ilan-pinto, TomerFi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
TomerFi
force-pushed
the
29-update-placement-snippets-and-templates
branch
from
May 3, 2023 18:33
24635b6
to
27b92b8
Compare
/lgtm |
Signed-off-by: Ilan Pinto <ilpinto@redhat.com>
TomerFi
force-pushed
the
29-update-placement-snippets-and-templates
branch
from
May 3, 2023 18:33
27b92b8
to
c509454
Compare
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.