Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Channel snippets and templates #26

Open
TomerFi opened this issue Dec 9, 2022 · 5 comments
Open

Update Channel snippets and templates #26

TomerFi opened this issue Dec 9, 2022 · 5 comments

Comments

@TomerFi
Copy link
Member

TomerFi commented Dec 9, 2022

Channel CRD can be found here.

Snippets are saved in our snippets directory.

Templates are saved in our templates directory.

VSCode Snippet Guide.
VSCode Using Snippets.

Related issue: #21

Templates are a part of our ocmNewProject command, no vscode docs available.
We have multiple templates, each template as its own Channel manifest.

@ilan-pinto
Copy link
Member

@TomerFi
I see that the new CRD supports "gates" and "matched labels" which are not mandatory fields. in addition, there are no official doc or examples in the OCM site.
do you think we need to add them to the snippets?

@TomerFi
Copy link
Member Author

TomerFi commented May 3, 2023

Well... we can push PRs to update OCM site too. :-)

Maybe, because these fields aren't mandated and not yet document, we can perhaps do it in another PR so we won't block #63 ?

@ilan-pinto
Copy link
Member

Of course. the changes are on another branch

@ilan-pinto
Copy link
Member

@TomerFi I checked that issue with @mikeshng. the "gates" field is no longer in use, it is there for backward compatibility.
meaning there are no changes required for snippets or templates.

@TomerFi
Copy link
Member Author

TomerFi commented May 4, 2023

Wait, we're replying to the wrong issue.
This issue is for the channel templates and snippets - which we have not done yet.

We're actually talking about the placement templates and snippets, #29 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants