Skip to content
This repository was archived by the owner on Feb 21, 2025. It is now read-only.

feat(protocol): Ecotone Marker that Scalars are Empty #45

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

refcell
Copy link
Contributor

@refcell refcell commented Jan 11, 2025

Description

In order to use the l1 block info from maili-protocol, a marker field must be added to the ecotone l1 block info so that
on the first ecotone block, the bedrock cost function can be used. revm sets this field using it's DB to indicate to the handler
that the bedrock cost function must be used.

Notice, we do not encode or decode this field from calldata and it is always false - by default and when used outside revm.

See: https://github.com/bluealloy/revm/blob/main/crates/optimism/src/l1block.rs#L69-L70

@refcell refcell self-assigned this Jan 11, 2025
@refcell
Copy link
Contributor Author

refcell commented Jan 11, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@refcell refcell added A-protocol Area: protocol crate C-feat Category: new feature or request labels Jan 11, 2025
@refcell refcell force-pushed the rf/ecotone-empty-scalar-marker branch from 5ccb39f to 3786cb1 Compare January 11, 2025 00:58
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smol comments, otherwise lgtm

Copy link
Contributor

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic lgtm, pending @emhane's re-review on the style.

@refcell refcell force-pushed the rf/ecotone-empty-scalar-marker branch from f2d272e to 1edefab Compare January 13, 2025 16:03
@refcell refcell merged commit ef896b3 into main Jan 13, 2025
20 checks passed
@refcell refcell deleted the rf/ecotone-empty-scalar-marker branch January 13, 2025 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-protocol Area: protocol crate C-feat Category: new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants