Skip to content

[Feature] Remove Empty Scalars Marker #1084

Closed
@refcell

Description

@refcell

Component

protocol

Describe the feature you would like

In op-rs/maili#45, the Ecotone L1 block info was amended to contain empty scalars marker bool for revm. Since scalars will always be empty in the first ecotone block, we may be able to remove the empty_scalars bool entirely and check if both the base_fee_scalar and blob_base_fee_scalar are zero.

This is what revm does when constructing the l1 block info from the db - the bool just acts as a helper. We should just be able to create a method on the L1BlockInfoEcotone that returns if both blob_base_fee_scalar and base_fee_scalar are zero.

Additional context

See conversation here.

Metadata

Metadata

Assignees

Labels

A-protocolArea: protocol crates

Type

Projects

  • Status

    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions