-
-
Notifications
You must be signed in to change notification settings - Fork 142
Conversation
@gungorbasa Hi, thanks for the PR. I'm a bit busy now but I will try to look into this weekend |
Sources/iOS/IndexPathConverter.swift
Outdated
} | ||
} | ||
|
||
public func convert<T>(changes: [Change<T>], section: Int) -> ChangeWithIndexPath { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have convention of 2 spaces indentation
, can you use that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, sorry for my sloppiness. I will fix it.
Sources/iOS/IndexPathConverter.swift
Outdated
} | ||
|
||
extension Int { | ||
fileprivate func toIndexPath(section: Int) -> IndexPath { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, we need to follow project convention :)
@gungorbasa This is great 🚀 |
@gungorbasa |
thank you @onmyway133 :) |
Unfortunately all that warnings are inevitable if you are using |
@gungorbasa yeah, that would be great ❤️ |
@onmyway133 ok. I will create another one in couple days and create a new merge request 😃 |
No description provided.