Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Texture example is added. #10

Merged
merged 2 commits into from
Feb 28, 2018
Merged

Conversation

gungorbasa
Copy link
Contributor

No description provided.

@onmyway133
Copy link
Owner

@gungorbasa Hi, thanks for the PR. I'm a bit busy now but I will try to look into this weekend

}
}

public func convert<T>(changes: [Change<T>], section: Int) -> ChangeWithIndexPath {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have convention of 2 spaces indentation, can you use that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, sorry for my sloppiness. I will fix it.

}

extension Int {
fileprivate func toIndexPath(section: Int) -> IndexPath {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, we need to follow project convention :)

@onmyway133 onmyway133 mentioned this pull request Feb 28, 2018
@onmyway133 onmyway133 merged commit a04bd5e into onmyway133:master Feb 28, 2018
@onmyway133
Copy link
Owner

@gungorbasa This is great 🚀

@onmyway133
Copy link
Owner

onmyway133 commented Feb 28, 2018

@gungorbasa Texture and PINCache generate lots of warnings 😢 Maybe we should move them to new demo project

@gungorbasa
Copy link
Contributor Author

thank you @onmyway133 :)

@gungorbasa
Copy link
Contributor Author

Unfortunately all that warnings are inevitable if you are using Texture. However, its an amazing library. It just makes everything so smooth :D
If you want, I can create a separate demo project for Texture. @onmyway133

@onmyway133
Copy link
Owner

@gungorbasa yeah, that would be great ❤️

@gungorbasa
Copy link
Contributor Author

@onmyway133 ok. I will create another one in couple days and create a new merge request 😃

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants