Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Need more public API #11

Closed
nixzhu opened this issue Feb 28, 2018 · 8 comments
Closed

Need more public API #11

nixzhu opened this issue Feb 28, 2018 · 8 comments

Comments

@nixzhu
Copy link
Contributor

nixzhu commented Feb 28, 2018

I have try to make extension for ASTableNode & ASCollectionNode (both from ASDK) with DeepDiff.
So the ChangeWithIndexPath, IndexPathConverter & Array.executeIfPresent need to be public.

Could you make it happen?

@onmyway133
Copy link
Owner

onmyway133 commented Feb 28, 2018

@nixzhu Hi, it seems this PR matches your requirement #10. I'm working on to make sure it's good to merge

@nixzhu
Copy link
Contributor Author

nixzhu commented Feb 28, 2018

@onmyway133 Thank you! I'll wait for it merged.

@onmyway133
Copy link
Owner

@nixzhu I just merge this #10. Can you check master to see if it works for you?

@nixzhu
Copy link
Contributor Author

nixzhu commented Mar 1, 2018

@onmyway133 It works for me. Thank you!

@onmyway133
Copy link
Owner

@nixzhu I will try to make new release soon

@onmyway133
Copy link
Owner

@nixzhu Hi, sorry for being late. Here is the new release with Swift 4.1 https://github.com/onmyway133/DeepDiff/releases/tag/1.2.0

@nixzhu
Copy link
Contributor Author

nixzhu commented Apr 12, 2018

@onmyway133 Thank you!

@nixzhu nixzhu closed this as completed Apr 12, 2018
@SolorzanoJose
Copy link

@nixzhu how did you write this extension?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants