FLIP 204: Add TargetDuration to Epoch models and API #4987
#5038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow/flow-go into misha/6894-buildjet-ci-test
[CI][Testing] Add BuildJet CI runners for unit tests, integration tests; cache Docker images
…nflow/flow-go into feature/flip-204-epoch-target-end-time
got this error: ``` go: module github.com/onflow/flow-core-contracts@9e8417b found (v0.0.0-20231120143830-9e8417b56122), but does not contain package github.com/onflow/flow-core-contracts/lib/go/templates ``` Maybe because templates did not change since previous version?
jordanschalm
requested review from
gomisha,
yhassanzadeh13 and
ramtinms
as code owners
jordanschalm
requested review from
durkmurder and
AlexHentschel
and removed request for
ramtinms,
gomisha and
yhassanzadeh13
2 tasks
jordanschalm
added a commit
that referenced
this pull request
Nov 22, 2023
Co-authored-by: Alexander Hentschel <alex.hentschel@axiomzen.co>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/flip-204-epoch-target-end-time #5038 +/- ##
==========================================================================
- Coverage 56.11% 56.06% -0.05%
==========================================================================
Files 957 965 +8
Lines 89274 89746 +472
==========================================================================
+ Hits 50095 50318 +223
- Misses 35427 35666 +239
- Partials 3752 3762 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jordanschalm
merged commit 445e0ab
into
feature/flip-204-epoch-target-end-time
54 checks passed
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional field from
EpochSetupevent which is needed to compute steady-state optimal view time, corresponding to onflow/flow-core-contracts#396.