Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLIP 204] Add targetDuration to EpochSetup #396

Merged
merged 5 commits into from
Nov 20, 2023

Conversation

jordanschalm
Copy link
Member

@jordanschalm jordanschalm commented Nov 20, 2023

This follows from #395, adding one additional piece of data which is required for Cruise Control.

⚠️ We'll need to upgrade FlowEpoch on Canary again once this is merged ⚠️

This is needed to compute tau, the steady-state optimal time/view,
in the cruise control system
Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready to merge?

@jordanschalm jordanschalm marked this pull request as ready for review November 20, 2023 18:26
@jordanschalm jordanschalm merged commit 246cc95 into access-slots Nov 20, 2023
2 checks passed
@jordanschalm jordanschalm deleted the jordan/394-add-duration-to-epochsetup branch November 20, 2023 18:26
joshuahannan added a commit that referenced this pull request Nov 21, 2023
…nd `EpochStart` event (#379)

* adds performance improvements to end of epoch operations

* construct proposed list within endStakingAuction

* make ci

* add first draft of open node slots code

* adds automatic open access node slots and a test

* add epoch start event

* make ci

* address PR comments

* use borrow for storage instead of load

* use borrow for more operations

* address PR comments

* use .remove

* add timing config struct

* add getter/setter, target time getter

* update constructor

* add transactions

* begin test updates

* add precondition that ref epoch in the past

guarantees time computation doesn't underflow

* add config update tests

* rm unused method

* test getting future epoch target end time

* adds performance improvements to end of epoch operations

* construct proposed list within endStakingAuction

* make ci

* add first draft of open node slots code

* adds automatic open access node slots and a test

* add epoch start event

* make ci

* address PR comments

* use borrow for storage instead of load

* use borrow for more operations

* address PR comments

* use .remove

* add epoch counter arguments to rewards and new epoch events

* [FLIP 204] Add `targetDuration` to `EpochSetup` (#396)

* add duration to EpochSetup

This is needed to compute tau, the steady-state optimal time/view,
in the cruise control system

* update generated files

* update tests

* tidy

* tidy

* add duration to refTimestamp

* make ci

---------

Co-authored-by: Jordan Schalm <jordan@dapperlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants