-
Notifications
You must be signed in to change notification settings - Fork 11
Return authorization list for SetCodeTx
type
#821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes introduce support for an Changes
Sequence Diagram(s)sequenceDiagram
participant TestSuite as JavaScript Test
participant PublicClient as publicClient
participant Node as Ethereum Node
TestSuite->>PublicClient: getTransaction({ hash })
PublicClient->>Node: eth_getTransactionByHash
Node-->>PublicClient: Transaction (with AuthorizationList)
PublicClient-->>TestSuite: Transaction object
TestSuite->>PublicClient: getTransactionReceipt({ hash })
PublicClient->>Node: eth_getTransactionReceipt
Node-->>PublicClient: Receipt
PublicClient-->>TestSuite: Receipt object
Note over TestSuite: Assert fields on transaction and receipt, including AuthorizationList
Suggested labels
Suggested reviewers
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@@ -381,6 +382,10 @@ func NewTransaction( | |||
result.BlobVersionedHashes = tx.BlobHashes() | |||
} | |||
|
|||
if tx.Type() > types.BlobTxType { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain this check here? And maybe add https://eip7702.io/#specification to the comments for reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, the checks can be a bit difficult to grasp. Added some helpful comments in 3ceea86 .
c70035f
to
3ceea86
Compare
@@ -361,6 +363,29 @@ func NewTransaction( | |||
size: tx.Size(), | |||
} | |||
|
|||
// After the Pectra hard-fork, the full list of supported tx types is: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comments.
Description
As described in the specification: https://eip7702.io/#specification, the new
SetCodeTx
type, has an authorization list:Example:
We need to include this information in the result of
eth_getTransactionByHash
JSON-RPC endpoint.For contributor use:
master
branchFiles changed
in the Github PR explorerSummary by CodeRabbit
New Features
Tests