Replace JSON-CDC with CCF for events #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also moved test function SDKEventToFlow to unittest package.
fxamacker
requested review from
bluesign,
devbugging,
janezpodhostnik and
turbolent
as code owners
janezpodhostnik
approved these changes
Jun 6, 2023
bluesign
approved these changes
Jun 6, 2023
turbolent
reviewed
Jun 6, 2023
turbolent
reviewed
Jun 6, 2023
Member
turbolent
left a comment
turbolent
left a comment
There was a problem hiding this comment.
Looks good! Just one question re: move of the functions and implications
turbolent
approved these changes
Jun 6, 2023
Merged
2 tasks
bors bot
added a commit
to onflow/flow-go
that referenced
this pull request
Jun 6, 2023
4417: [Exec] Use CCF in self-describing mode to encode events (replaces JSON-CDC) r=fxamacker a=fxamacker Updates onflow/cadence#2283 This PR uses CCF in fully self-describing mode, so events will encode to about 1/2 the size of JSON-CDC encoding. Using CCF in partially self-describing mode can encode events to 1/14 the size of JSON-CDC but that requires other changes outside of CCF codec and other resulting work. ### TODO - [x] Update this PR after #4390 is merged. - [x] After the update, run CI tests and resolve any issues. :heavy_check_mark: Requires PR #4390 (merged on June 2, 2023). :heavy_check_mark: Requires PR onflow/cadence#2528 ✔️ Requires PR onflow/cadence#2529 ✔️ Requires PR onflow/flow-emulator#408 Co-authored-by: Faye Amacker <33205765+fxamacker@users.noreply.github.com> Co-authored-by: Amlandeep Bhadra <amlandeep1912@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #407
Unblocks onflow/flow-go#4417
Description
Replace JSON-CDC with CCF for encoding/decoding events.
Move test function
SDKEventToFlowto unittest package.Update flow-go to last commit in onflow/flow-go#4417.
Update Cadence to v0.39.2.
This is required for integration tests to pass in onflow/flow-go#4417.
Thanks @janezpodhostnik for looking into this and discussion in Slack. 👍
For contributor use:
masterbranchFiles changedin the GitHub PR explorer