Fix publicKey to have matching static and runtime types
#2528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two versions of AccountKeyAdded and AccountKeyRemoved events. Currently, publicKey field's static type and runtime type are different in the latest version. For example, `flow.AccountKeyAdded`: - event type has `publicKey` field type `[UInt8]` (static type). - event value has `publicKey` field as `Struct` (runtime type). This change updates publicKey field's static type to match runtime type for both events in the lastest version.
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 1044a9b Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov Report
@@ Coverage Diff @@
## master #2528 +/- ##
=======================================
Coverage 78.46% 78.46%
=======================================
Files 336 336
Lines 77298 77298
=======================================
Hits 60652 60652
Misses 14376 14376
Partials 2270 2270
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dsainati1
reviewed
Jun 5, 2023
dsainati1
approved these changes
Jun 5, 2023
turbolent
approved these changes
Jun 5, 2023
Member
turbolent
left a comment
turbolent
left a comment
There was a problem hiding this comment.
Thank you for fixing this! We should add two runtime tests that assert the types are correct
Member
|
Just checked, the existing/modified runtime tests already should be sufficient, so this can be merged |
Merged
2 tasks
bors bot
added a commit
to onflow/flow-go
that referenced
this pull request
Jun 6, 2023
4417: [Exec] Use CCF in self-describing mode to encode events (replaces JSON-CDC) r=fxamacker a=fxamacker Updates onflow/cadence#2283 This PR uses CCF in fully self-describing mode, so events will encode to about 1/2 the size of JSON-CDC encoding. Using CCF in partially self-describing mode can encode events to 1/14 the size of JSON-CDC but that requires other changes outside of CCF codec and other resulting work. ### TODO - [x] Update this PR after #4390 is merged. - [x] After the update, run CI tests and resolve any issues. :heavy_check_mark: Requires PR #4390 (merged on June 2, 2023). :heavy_check_mark: Requires PR onflow/cadence#2528 ✔️ Requires PR onflow/cadence#2529 ✔️ Requires PR onflow/flow-emulator#408 Co-authored-by: Faye Amacker <33205765+fxamacker@users.noreply.github.com> Co-authored-by: Amlandeep Bhadra <amlandeep1912@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2525
Updates onflow/flow-go#4417
Changes
This PR updates
publicKeyfield's static type to match runtime type forAccountKeyAddedandAccountKeyRemovedevents.Reason for change
Currently,
publicKeyfield's static type and runtime type are different in the latest version ofAccountKeyAddedandAccountKeyRemovedevents.For example,
flow.AccountKeyAdded:publicKeyfield type[UInt8](static type).publicKeyfield asStruct(runtime type).masterbranchFiles changedin the Github PR explorer