Fixes fillNodeRoleSlots() to not remove from array while it is being accessed
#448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuahannan
requested review from
jordanschalm,
janezpodhostnik and
sisyphusSmiling
janezpodhostnik
approved these changes
Sep 11, 2024
jordanschalm
approved these changes
Sep 11, 2024
sisyphusSmiling
approved these changes
Sep 11, 2024
joshuahannan
force-pushed
the
fill-slots-error
branch
from
15b2116
to
8f8fc0f
Compare
…ting out of bounds access
|
@joshuahannan should this be merged now? |
|
yes, I'll merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #443
Fixes a bug that was causing the system chunk to fail when the end staking auction was executing.
The code is in the loop in
fillNodeRoleSlots()function that refunds candidate nodes who didn't get chosen for staking. The loop was removing items from thecandidateNodesForRoledictionary in the same loop as the dictionary being accessed. The index that was being accessed was randomly generated, so it would sometimes cause an out of bounds error. This likelihood of the error increases as the number of candidate nodes increases.The fix moves the code to remove from the candidate node list to after the loop has completed
Still working on a test for the change