Skip to content

Fix bug in fillNodeRoleSlots() that removes nodes from the same list it is indexing into #443

Closed

Description

Problem

In FlowIDTableStaking.Admin.fillNodeRoleSlots(), there is a loop that removes nodes from the same list it indexes to.
This can cause an error when ending the staking auction or resetting the epoch if the random index chosen is out of bounds.

Steps to Reproduce

TBD

Acceptance Criteria

This may have been already fixed before and we lost the commit. Need to find out if that is somewhere and integrate it with the current code.
When running reset epoch X number of times (high number) with nodes registered but not staked, should never fail with out of bounds index.

Context

This causes the reset epoch and end staking auction to fail randomly sometimes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

FeedbackbugSomething isn't working

Type

No type

Projects

  • Status

    ✅ Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions