Remove pub, priv and pub(set) documentation #146
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Some of the updated docs reflect contracts that are currently deployed and would not reflect the versions shown in this PR, like FlowToken, FlowIDTableStaking, NFTStorefront, StakingCollection, FlowEpoch, and the token standards.
In your description, you said you don't want to update the docs for deployed contracts until the contracts have been updated, so we should revert all of those until the contracts have been updated, right?
There was a problem hiding this comment.
All the tutorials have separate saved playground projects which will also need to be updated to reflect these changes
There was a problem hiding this comment.
I'll create an issue for it and add it to our backlog. Not sure exactly when we'll get to it, but it should hopefully be soon
|
cc @SupunS @joshuahannan can you take another look at this? |
With onflow/cadence#2540 merged, these access modifiers are going away in Stable Cadence.
Note that
docs/concepts/staking/05-epoch-scripts-events.mdanddocs/tooling/unity-sdk/samples/nft-browser.mdstill containpub(set)access modifiers, but given that these reflect real contracts, I did not want to update them unilaterally. Once these contracts are updated, the docs should change to match them.