Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update saved tutorial projects to not use pub or priv access modifiers #148

Closed
9 tasks
joshuahannan opened this issue Jun 23, 2023 · 1 comment
Closed
9 tasks
Assignees
Labels
documentation Improvements or additions to documentation SC-Eng

Comments

@joshuahannan
Copy link
Member

Issue to be solved

We're removing pub and priv modifiers from the language and docs in #146
so the saved playground projects for the tutorials need to also be updated.

Suggest A Solution

  • Copy the projects for each tutorial
  • Remove the access modifiers and replace them with access(all) and access(self)
  • Save and export new projects
  • add these links to their respective tutorials
  • Test the links in incognito mode to make sure they are loading properly and that the contracts still deploy and transactions run properly
  • Hello World
  • Resources
  • Capabilities
  • NFT 1
  • NFT 2
  • FT
  • Marketplace
  • Voting
  • Composable resources

What are you currently working on that this is blocking?

No response

@joshuahannan joshuahannan added documentation Improvements or additions to documentation SC-Eng labels Jun 23, 2023
@joshuahannan joshuahannan self-assigned this Jun 26, 2023
@nialexsan
Copy link
Collaborator

currently the changes are reflected in the next version:
https://developers.flow.com/next/cadence/anti-patterns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation SC-Eng
Projects
None yet
Development

No branches or pull requests

2 participants