Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize interpreter: Move evaluation of expressions and statements to separate files #682

Merged
merged 3 commits into from
Mar 11, 2021
Merged

Optimize interpreter: Move evaluation of expressions and statements to separate files #682

merged 3 commits into from
Mar 11, 2021

Conversation

turbolent
Copy link
Member

⚠️ Depends on #681
Work towards #678

The code for the interpreter is all in one file. Split it into separate files to make it more maintainable.

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this Mar 10, 2021
@turbolent turbolent mentioned this pull request Mar 10, 2021
Merged
6 tasks
SupunS
SupunS approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Makes it so much easier to read the codebase.

I guess this is simply a 'move', with no new changes?

runtime/interpreter/interpreter_expression.go Show resolved Hide resolved
runtime/interpreter/interpreter_expression.go Outdated Show resolved Hide resolved
runtime/interpreter/interpreter_statement.go Outdated Show resolved Hide resolved
@turbolent turbolent force-pushed the bastian/optimize-interpreter-3 branch from 22079b7 to 7b92c9d Compare March 11, 2021 23:29
Base automatically changed from bastian/optimize-interpreter-3 to master March 11, 2021 23:38
@turbolent
Copy link
Member Author

Yep, no changes, just a move 👍

@turbolent turbolent force-pushed the bastian/optimize-interpreter-4 branch from 77611ab to 8c0c12d Compare March 11, 2021 23:45
@turbolent turbolent merged commit c3dbd3a into master Mar 11, 2021
@turbolent turbolent deleted the bastian/optimize-interpreter-4 branch March 11, 2021 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupunS SupunS SupunS approved these changes

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik

Assignees

@turbolent turbolent

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turbolent @SupunS