Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add encoding/decoding dictionary static type info #1036

Merged
merged 11 commits into from
Jun 30, 2021
Merged

Add encoding/decoding dictionary static type info #1036

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0ee0c91
Add encoding/decoding array static type info
SupunS Jun 29, 2021
8b62e52
Split and refactor array head decoding
SupunS Jun 30, 2021
dc72ec5
Add encoding/decoding dictionary static type info
SupunS Jun 29, 2021
afe7ae8
Re-arrange encoding format to move types to the start
SupunS Jun 30, 2021
f00489b
Ignore metainfo decoding for older encoding versions
SupunS Jun 30, 2021
d0306c5
Merge branch 'supun/array-static-type' of https://github.com/onflow/c…
SupunS Jun 30, 2021
e86ca0c
Merge branch 'supun/array-static-type' into supun/dictionary-static-type
SupunS Jun 30, 2021
a1e9d97
Store static type in dictionary value. Fix tests
SupunS Jun 30, 2021
a8a063f
Remove obsolete todo
SupunS Jun 30, 2021
4d183e1
Merge branch 'feature/container-static-types' into supun/dictionary-s…
turbolent Jun 30, 2021
f913717
remove delegation to previous decoder
turbolent Jun 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'supun/array-static-type' of https://github.com/onflow/c… 
…adence into supun/dictionary-static-type
  • Loading branch information
@SupunS
SupunS committed Jun 30, 2021
commit d0306c551d69964f242a6b77ae815dd1d3d50b9c
2 changes: 1 addition & 1 deletion runtime/interpreter/decode.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1876,7 +1876,7 @@ func decodeArrayElements(array *ArrayValue, elementContent []byte) error {
}

func decodeDictionaryMetaInfo(v *DictionaryValue, content []byte) error {
if v.encodingVersion == 4 {
if v.encodingVersion < 4 {
// In encoding version 4, no meta info was available for dictionaries.
// The raw content only consist of the entries.
v.entriesContent = content
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.