Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add encoding/decoding dictionary static type info #1036

Merged
merged 11 commits into from
Jun 30, 2021
Merged

Add encoding/decoding dictionary static type info #1036

merged 11 commits into from
Jun 30, 2021

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Jun 29, 2021 •
edited
Loading

Work towards #870

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

turbolent
turbolent reviewed Jun 29, 2021
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@turbolent turbolent mentioned this pull request Jun 29, 2021
Closed
23 tasks
turbolent
turbolent reviewed Jun 29, 2021
View reviewed changes
runtime/interpreter/decode.go Outdated Show resolved Hide resolved
runtime/interpreter/decode.go Outdated Show resolved Hide resolved
runtime/interpreter/encode.go Outdated Show resolved Hide resolved
@turbolent
Copy link
Member

@fxamacker Could you please also have a look at this PR? It changes the storage format to add static type information for dictionaries, the work is similar to your earlier work on optimizing encoding and decoding. Thank you!

@turbolent turbolent requested a review from fxamacker June 29, 2021 18:56
@SupunS SupunS force-pushed the supun/dictionary-static-type branch 2 times, most recently from 92cd227 to 6a2d1bc Compare June 30, 2021 02:58
@SupunS SupunS force-pushed the supun/dictionary-static-type branch from 6a2d1bc to afe7ae8 Compare June 30, 2021 04:32
@SupunS SupunS marked this pull request as ready for review June 30, 2021 09:40
@SupunS SupunS self-assigned this Jun 30, 2021
Base automatically changed from supun/array-static-type to feature/container-static-types June 30, 2021 17:44
turbolent
turbolent reviewed Jun 30, 2021
View reviewed changes
runtime/interpreter/encode.go
Comment on lines -913 to +915
// Encode keys (as array) at array index encodedDictionaryValueKeysFieldKey
// (1) Encode dictionary static type at array index encodedDictionaryValueTypeFieldKey
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

turbolent
turbolent approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👏

@turbolent turbolent merged commit c3e391f into feature/container-static-types Jun 30, 2021
@turbolent turbolent deleted the supun/dictionary-static-type branch June 30, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@fxamacker fxamacker Awaiting requested review from fxamacker

Assignees

@SupunS SupunS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SupunS @turbolent