Skip to content

Ruby 2.2+ compatibility #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

methodmissing
Copy link

References #8

See Shopify#1 for further context.

@jtdowney
Copy link

jtdowney commented Jun 13, 2016

Wouldn't this break compatibility with ruby < 2.2? Since in those versions the cipher context is just data and not typed data.

@methodmissing
Copy link
Author

It'll break - I'll PR a backwards compatible change. Thx for flagging.

@methodmissing
Copy link
Author

@jtdowney inbound via Shopify#2 - feel free to drop comments there.

@methodmissing
Copy link
Author

methodmissing commented Jun 14, 2016

Merged the PR upstream. Review bump with the full changeset that also is backwards compat as per comments from @jtdowney in Shopify#2 (comment)

@jtdowney
Copy link

I am not sure who has the ability to merge this and bump the version but @Lordnibbler owns the rubygem.

@Lordnibbler
Copy link
Contributor

@jtdowney I do not have the ability to merge any longer, you would need someone at OneLogin to do this for you. I am the owner of the gem on Rubygems and could cut a new release, but ideally someone at OneLogin should take ownership and handle this in the future.

Let me try and ping some folks:
@tinifni @prateekm21 @chunkychode @christianbpedersen

@ryanong
Copy link

ryanong commented Sep 27, 2017

@Lordnibbler I think at this point it might be time to fork the source and give it to someone IE shopify to maintain.

LONG LIVE THE MIT LICENSE

@Lordnibbler
Copy link
Contributor

@ryanong sorry I wish I could but I haven’t worked with onelogin since 2015, so I’m no longer an owner :(

@ryanong
Copy link

ryanong commented Sep 27, 2017

I mean as the push owner of the gem, you could change the source of the gem.

@tibbon
Copy link

tibbon commented Apr 25, 2018

And status update here? Or is this dead in the water?

@Lordnibbler
Copy link
Contributor

I no longer have write access to this Gem, and although Rubygems thinks I am the owner/author I no longer have access to any machines with credentials to change owners.

Someone from Onelogin would have to help. I'm not entirely sure how to tell who can do this.

@jtdowney
Copy link

I am shooting in the dark here, but I saw that @pitbulk pushed to onelogin/ruby-saml recently so perhaps they know how to get this either a) maintained at onelogin or b) transferred so the community can support it.

@pitbulk
Copy link

pitbulk commented Apr 25, 2018

Hi, I will try to ask at onelogin who can do it. (I pushed ruby-saml with my user, not with onelogin account that is the owner)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants