This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Ruby 2.2+ compatibility #1
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References issue onelogin#8
Gist of the problem:
OpenSSL
etc. was setup in the extension which can lead to namespace clobbering depending on usage context.Gist of the fixes:
openssl
on extension init and letOpenSSL::Cipher
andOpenSSL::OpenSSLError
be references to the constants defined inext/openssl
instead.m
and classes prefixed withc
(VALUE mOSSLCipher
->VALUE cOSSLCipher
)RTYPEDDATA_TYPE(obj)
macro for parity for the typed data definition that theaead
extension reads with the one thatOpenSSL::Cipher
allocates objects with.@pallan @csfrancis @jnormore