Skip to content

fix(models): adapt chunk's contains() definition. #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2024
Merged

fix(models): adapt chunk's contains() definition. #755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions tests/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,30 +18,47 @@ class TestChunk:
@pytest.mark.parametrize(
"chunk1, chunk2, result",
[
(
pytest.param(
Chunk(start_offset=0, end_offset=10),
Chunk(start_offset=1, end_offset=2),
True,
id="starts-after-ends-before",
),
(
pytest.param(
Chunk(start_offset=0, end_offset=10),
Chunk(start_offset=11, end_offset=12),
False,
id="starts-after-ends-after",
),
(
pytest.param(
Chunk(start_offset=0, end_offset=10),
Chunk(start_offset=15, end_offset=20),
False,
id="starts-after-ends-after",
),
(
pytest.param(
Chunk(start_offset=1, end_offset=2),
Chunk(start_offset=3, end_offset=5),
False,
id="starts-after-ends-after",
),
(
pytest.param(
Chunk(start_offset=0, end_offset=10),
Chunk(start_offset=1, end_offset=10),
True,
id="starts-after-ends-same",
),
pytest.param(
Chunk(start_offset=0, end_offset=10),
Chunk(start_offset=0, end_offset=9),
True,
id="starts-same-ends-before",
),
pytest.param(
Chunk(start_offset=0, end_offset=10),
Chunk(start_offset=0, end_offset=10),
False,
id="starts-same-ends-same",
),
],
)
Expand Down
3 changes: 3 additions & 0 deletions unblob/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ def contains(self, other: "Chunk") -> bool:
return (
self.start_offset < other.start_offset
and self.end_offset >= other.end_offset
) or (
self.start_offset <= other.start_offset
and self.end_offset > other.end_offset
)

def contains_offset(self, offset: int) -> bool:
Expand Down