fix(models): adapt chunk's contains() definition. #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qkaiser
force-pushed
the
753-overlap-fix
branch
from
dc6e063 to
de65ff0
Compare
We were considering that a chunk A contains a chunk B if chunk B start after chunk A and ends before or on the same offset than chunk A. This caused issues with compressed DMG images where two handlers would rightfully identify two chunks: - a bzip chunk starting at offset 0 and ending before the DMG plist - a DMG chunk starting at offset 0 and ending after the DMG footer We therefore adapted our definition of contains() where a contained chunk can start at the same offset but ends before, or start after the containing chunk but can end on the same offset.
qkaiser
force-pushed
the
753-overlap-fix
branch
from
de65ff0 to
c8f24fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were considering that a chunk A contains a chunk B if chunk B start after chunk A and ends before or on the same offset than chunk A.
This caused issues with compressed DMG images where two handlers would rightfully identify two chunks:
We therefore adapted our definition of contains() where a contained chunk can start at the same offset but ends before, or start after the containing chunk but can end on the same offset.
Resolve #753