-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[L0 v2] make v2 adapter usable through the loader #2191
base: main
Are you sure you want to change the base?
Conversation
@pbalcer do you think we could expose L0 v2 adapter through ur_platform_backend_t so we woulnd't have to use a special value like I did in this PR? We expect L0 to coexists along L0 v2 for some time, anyway, right? |
I've made this PR because I realized that after #2168 v2 tests are failing. @RossBrunton from what I observed if |
We could, but I'd be worried how SYCL would behave, having to chose the correct implementation.
I would expect to remove the legacy adapter after a single release of them coexisting. We wouldn't want to implement features in both for very long. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine as a temporary solution.
@pbalcer Right, but do already have a timeline for implementing all the remaining queue modes? Without them, v2 won't be a full replacement for the legacy adapter. |
No description provided.