Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[L0 v2] make v2 adapter usable through the loader #2191

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

igchor
Copy link
Member

@igchor igchor commented Oct 10, 2024

No description provided.

@igchor igchor requested review from a team as code owners October 10, 2024 23:03
@igchor
Copy link
Member Author

igchor commented Oct 10, 2024

@pbalcer do you think we could expose L0 v2 adapter through ur_platform_backend_t so we woulnd't have to use a special value like I did in this PR? We expect L0 to coexists along L0 v2 for some time, anyway, right?

@github-actions github-actions bot added loader Loader related feature/bug conformance Conformance test suite issues. level-zero L0 adapter specific issues labels Oct 10, 2024
@igchor
Copy link
Member Author

igchor commented Oct 10, 2024

I've made this PR because I realized that after #2168 v2 tests are failing.

@RossBrunton from what I observed if -DUR_CONFORMANCE_TEST_LOADER=1 is passed then both -loader and regular tests (that should be using UR_ADAPTER_FORCE_LOAD) are actually using the loader. I don't even see UR_ADAPTER_FORCE_LOAD anywhere in the logs when I run ctest with --verbose. I wonder if do_add_test handles env variables correctly. Looking at https://github.com/RossBrunton/unified-runtime/blob/8c5c5ad17adc400c42b2c3d58df547a4e9dd2076/test/conformance/CMakeLists.txt#L21C32-L21C35 I don't see the env being anywhere.

@pbalcer
Copy link
Contributor

pbalcer commented Oct 11, 2024

We could, but I'd be worried how SYCL would behave, having to chose the correct implementation.
Maybe the solution here is to use the appropriate value, but instead hide the adapter by default from urAdapterGet if it wasn't explicitly selected using ONEAPI_DEVICE_SELECTOR=level_zero2:* or something.

We expect L0 to coexists along L0 v2 for some time, anyway, right?

I would expect to remove the legacy adapter after a single release of them coexisting. We wouldn't want to implement features in both for very long.

Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine as a temporary solution.

@igchor
Copy link
Member Author

igchor commented Oct 11, 2024

I would expect to remove the legacy adapter after a single release of them coexisting. We wouldn't want to implement features in both for very long.

@pbalcer Right, but do already have a timeline for implementing all the remaining queue modes? Without them, v2 won't be a full replacement for the legacy adapter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conformance Conformance test suite issues. level-zero L0 adapter specific issues loader Loader related feature/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants