Improved adapter selection in CTS testing #2168
Merged
+256
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ci/cd
RossBrunton
force-pushed
the
ross/backend
branch
3 times, most recently
from
6552f47
to
2809b33
Compare
|
Currently this doesn't do the loader testing in CI, I'm going to do that as a separate change. |
RossBrunton
force-pushed
the
ross/backend
branch
from
2809b33
to
90b9a46
Compare
EwanC
approved these changes
Oct 4, 2024
RossBrunton
force-pushed
the
ross/backend
branch
from
90b9a46
to
0957739
Compare
aarongreig
reviewed
Oct 4, 2024
test/conformance/adapter/adapter_adapter_native_cpu_loader.match
Outdated
Show resolved
Hide resolved
martygrant
reviewed
Oct 4, 2024
RossBrunton
force-pushed
the
ross/backend
branch
4 times, most recently
from
88e9994
to
3d6b6b7
Compare
RossBrunton
force-pushed
the
ross/backend
branch
from
3d6b6b7
to
d33b935
Compare
github-actions
bot
added
the
specification
RossBrunton
force-pushed
the
ross/backend
branch
from
d33b935
to
5d033ed
Compare
RossBrunton
commented
Oct 8, 2024
| @@ -42,15 +67,6 @@ std::ostream &operator<<(std::ostream &out, | |||
| return out; | |||
| } | |||
|
|
|||
| std::ostream &operator<<(std::ostream &out, const ur_device_handle_t &device) { | |||
There was a problem hiding this comment.
This has been removed since we are importing a few more headers which define this elsewhere.
kbenzie
reviewed
Oct 8, 2024
RossBrunton
force-pushed
the
ross/backend
branch
from
5d033ed
to
3637715
Compare
kbenzie
reviewed
Oct 9, 2024
RossBrunton
force-pushed
the
ross/backend
branch
2 times, most recently
from
dcc2b12
to
f8f1ccb
Compare
The CTS tests now have an additional --backend option, and the --platform option allows specifying platforms per-device. In addition, new targets have been added that test the "loader"; that is, where the adapter isn't forced.
RossBrunton
force-pushed
the
ross/backend
branch
from
f8f1ccb
to
8c5c5ad
Compare
kbenzie
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CTS tests now have an additional --backend option, and the --platform
option allows specifying platforms per-device. In addition, new targets
have been added that test the "loader"; that is, where the adapter isn't
forced.